Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Composer #10

Closed
onigoetz opened this issue Mar 7, 2013 · 4 comments
Closed

Composer #10

onigoetz opened this issue Mar 7, 2013 · 4 comments

Comments

@onigoetz
Copy link

onigoetz commented Mar 7, 2013

Hi,

is there any plan or idea to include composer inside XHGUI ?

it would help for autoloading and inclusion of outer projects like twig

if yes, I would be happy to provide a pull request.

@markstory
Copy link
Member

Twig is already in the code though. I could see a use for composer if we had more dependencies. As it stands with only one, I don't think it makes much sense. Also including composer means there are more steps to getting things setup and working.

@onigoetz
Copy link
Author

onigoetz commented Mar 7, 2013

I know that twig is already included. But with composer that would mean
that it'es easier to upgrade. Also you could provide a zip package
containing the dependencies.

wouldn't it also be nicer to use a microframework to handle the routing/url
stuff ? that could be handled in dependencies.

Le jeudi 7 mars 2013, Mark Story a écrit :

Twig is already in the code though. I could see a use for composer if we
had more dependencies. As it stands with only one, I don't think it makes
much sense. Also including composer means there are more steps to getting
things setup and working.


Reply to this email directly or view it on GitHubhttps://github.com//issues/10#issuecomment-14572535
.

@markstory
Copy link
Member

Providing zip files that aren't git repo dumps means we'd need to setup alternate hosting as github doesn't support that anymore. Github also doesn't include submodules in zip files so that's not really a viable option either.

A micro framework might be nicer, but at this point xhgui is pretty small, and a micro framework wouldn't really add much in terms of benefit. I'm a big proponent of frameworks, but in this case I'm not sure there would be much value added by adopting one. The big drawback would be that xhgui would be considerably larger, as most frameworks easily dwarf the current xhgui codebase.

If in the future xhgui becomes a larger thing adopting a framework would make sense.

@onigoetz
Copy link
Author

onigoetz commented Mar 7, 2013

Yeah you're right. it doesn't make sense for the moment.

@onigoetz onigoetz closed this as completed Mar 7, 2013
glensc pushed a commit to glensc/xhgui that referenced this issue Aug 25, 2020
Update README.md with current compatibility info
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants