Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JSON-LD/RDF view #56

Closed
atomrab opened this issue Jul 8, 2015 · 7 comments
Closed

JSON-LD/RDF view #56

atomrab opened this issue Jul 8, 2015 · 7 comments

Comments

@atomrab
Copy link

atomrab commented Jul 8, 2015

Is this going to reappear as a visualization option in this version of the client? Data model aside, it would help to surface some of the information we're hiding (e.g. if the language/script identifiers from the spreadsheet made it in or not). Also, it's good for letting people have a quick look at how the period definitions are structured in practice.

@ptgolden
Copy link
Member

ptgolden commented Jul 8, 2015

I forgot to add it back in, whoops

@ptgolden
Copy link
Member

ptgolden commented Jul 8, 2015

In terms of "information we're hiding", you can click on a period to see all the information there is about it.

@atomrab
Copy link
Author

atomrab commented Jul 8, 2015

But are those original language tags in the serialized form? There must be something that tells you a label is in Ukrainian, since you're sorting by it, but it doesn't appear in the period view. Also, there's the collection-level information, like the VIAF id of authors, that isn't visible without the JSON-LD view, unless I'm missing something.

@ptgolden
Copy link
Member

ptgolden commented Jul 8, 2015

But are those original language tags in the serialized form?

I don't know what you're referring to.

The sort label is the "original label" value, i.e. what appeared in the text. If you think it should be something different, let me know.

@atomrab
Copy link
Author

atomrab commented Jul 9, 2015

I think I didn't express myself well. In the spreadsheet, we had ISO codes
for the script and language of the original label. In the data model for
the current dataset, the original label has no language or script code (and
this is true when you look at the period definition info -- the alt label
is coded en-lat, the original label not).

But those ISO codes for the original labels must be preserved somewhere,
because you can now filter by language. I'm trying to figure out where
those are.

This is mainly because, if I understand the current data model correctly,
we need to add an additional language-coded altlabel to all
periods originally designated with non-English labels (since original label
has no language code). I can do this manually if necessary -- it's only a
couple of hundred -- but if those ISO codes are still there, maybe we could
do it programmatically.

Does this make sense, or am I misunderstanding something?

On Wednesday, July 8, 2015, Patrick Golden <notifications@github.com
javascript:_e(%7B%7D,'cvml','notifications@github.com');> wrote:

But are those original language tags in the serialized form?

I don't know what you're referring to.

The sort label is the "original label" value, i.e. what appeared in the
text. If you think it should be something different, let me know.


Reply to this email directly or view it on GitHub
#56 (comment)
.

@ptgolden
Copy link
Member

ptgolden commented Jul 9, 2015

It makes sense.

In the data model for the current dataset, the original label has no language or script code

The original label has a language and script code in the current dataset. In the JSON-LD, it's in the originalLabel property. The value of that label (without the script or language) is duplicated in the label property. This is not ideal, but that duplication was a tradeoff we made in order to 1) make the JSON easier to process, and 2) create RDF properties for skos:prefLabel values and skos:altLabel localized values.

Filtering by language works with any language applied to the period (original or alternate). All 1791 periods currently have English labels, whether for the original or alternate, which is indicated in the filtering interface. It would be definitely useful in a future version to differentiate between filtering original and alternate labels.

In terms of viewing the details of a specific period, I forgot to put the script tag for the original language. I will add that. Nothing has been lost.

@ptgolden
Copy link
Member

fixed by 94845f5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants