Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Most periods are missing spatialCoverageDescription #24

Closed
ptgolden opened this issue Jul 8, 2015 · 19 comments
Closed

Most periods are missing spatialCoverageDescription #24

ptgolden opened this issue Jul 8, 2015 · 19 comments
Assignees
Labels

Comments

@ptgolden
Copy link
Member

ptgolden commented Jul 8, 2015

Out of 1791 period definitions, 1207 have a blank field for spatial coverage description. I'm pretty sure that in the vast majority of cases, these periods have one single entry in spatial coverage (as in, one country). It would probably make sense to copy the text of the country name to the description.

@atomrab
Copy link

atomrab commented Jul 8, 2015

We left this blank in two cases: when the coverage was unstated but obvious, and when the coverage asserted by the author was also one or more modern nation states (so we could just copy it directly).

I think that you're right, it's probably easiest to copy these over from spatial coverage. But we'll need to be rigorous in the future about differentiating between an explicit statement on the part of the source and an inference, however obvious.

@rybesh
Copy link
Member

rybesh commented Jul 8, 2015

We left this blank in two cases: when the coverage was unstated but obvious, and when the coverage asserted by the author was also one or more modern nation states

Is there any way of reconstructing which of these was the case for the 1207 blanks?

@atomrab
Copy link

atomrab commented Jul 8, 2015

Sort of, by collection. All the Fasti definitions are the latter
(author-asserted), as are PAS, English Heritage, ARENA, Jamieson 2007,
Historiska, Rijksdienst, and Open Context. Pleiades, the UCLA Encyclopedia
of Egyptology and all the values that came in from GeoDia, at least where
spatial coverage label is blank
, are the former (unstated but obvious).
The British Museum values, when they go in, are also the former -- where
there's no label, the coverage was obvious but not explicit.

But that doesn't go item by item. Will it be enough?

Adam

On Wed, Jul 8, 2015 at 12:33 PM, Ryan Shaw notifications@github.com wrote:

We left this blank in two cases: when the coverage was unstated but
obvious, and when the coverage asserted by the author was also one or more
modern nation states

Is there any way of reconstructing which of these was the case for the
1207 blanks?


Reply to this email directly or view it on GitHub
#24 (comment)
.

@ptgolden
Copy link
Member Author

ptgolden commented Jul 9, 2015

OK, so:

Author asserted

  • Fasti
  • PAS
  • English Heritage
  • ARENA
  • Jamieson 2007
  • Historiska
  • Rijksdienst
  • Open Context

Unstated but obvious

  • Pleiades
  • UCLA Encyclopedia of Egyptology
  • GeoDia (where coverage is blank)
  • British Museum

The author-asserted values can be immediately copied to the spatialCoverageDescription field. Should the same be done for the unstated-but-obvious values?

More generally, should a spatial coverage description be required for each and every period? If that is the case, it will have consequences for the period form.

@rybesh
Copy link
Member

rybesh commented Jul 9, 2015

should a spatial coverage description be required for each and every period?

I think that the "unstated but obvious" cases should remain without a spatialCoverageDescription so that we aren't putting words in the original source's mouth.

@atomrab
Copy link

atomrab commented Jul 9, 2015

For what it's worth, the entries for Pleiades and the British Museum
already have an editorial note explaining where the spatial coverage came
from. I can also easily add a note for the UEE, since there aren't many
entries and by default it's obviously referring to Egypt.

The same isn't true of the GeoDia entries, but we could add a bulk note to
all those without a description indicating that spatial coverage was
inferred during the GeoDia data entry process.

On Thu, Jul 9, 2015 at 7:42 AM, Ryan Shaw notifications@github.com wrote:

should a spatial coverage description be required for each and every
period?

I think that the "unstated but obvious" cases should remain without a
spatialCoverageDescription so that we aren't putting words in the
original source's mouth.


Reply to this email directly or view it on GitHub
#24 (comment)
.

@ptgolden
Copy link
Member Author

ok, I'll go ahead and copy spatial coverages over to spatialCoverageDescription for the "author asserted" cases above.

@ptgolden
Copy link
Member Author

I don't see any sources that correspond to English Heritage or Open Context. Are they under different titles, or not in the current "Canonical" dataset?

@atomrab
Copy link

atomrab commented Aug 24, 2015

Sorry, should have been clearer on those. By "English Heritage", I meant the Heritage Data collection (http://n2t.net/ark:/99152/p0kh9ds), which derived the periods we recorded from the English Heritage thesaurus; and by "Open Context" I meant Anderson et al., Digital Index of North American Archaeology (DINAA) (http://n2t.net/ark:/99152/p086kj9).

@ptgolden
Copy link
Member Author

The first batch of fixes is in https://test.perio.do/#/patches/https://test.perio.do/patches/6/. I'll add the other two in another patch.

@ptgolden
Copy link
Member Author

Also the British Museum data can be approved at https://test.perio.do/#/patches/https://test.perio.do/patches/5/

@atomrab
Copy link

atomrab commented Aug 24, 2015

It occurs to me that there is a basic spatial assertion in one of the other unlabeled sources: the spatial element of the Cambridge Companion to the Aegean Bronze Age is "the Aegean". Should I go through and add this to all those values, or can that be done easily as a batch -- or do you guys think it's still too much a stretch in terms of authorial intent, and we should ignore it?

@ptgolden
Copy link
Member Author

do you guys think it's still too much a stretch in terms of authorial intent, and we should ignore it

I think that you're the expert there. If you want me to, I'll add it in my followup patch.

@atomrab
Copy link

atomrab commented Aug 24, 2015

Let's do it. I think it's fair, based on the title of the work.

@rybesh rybesh self-assigned this Jan 26, 2017
@rybesh rybesh added bug and removed bug labels Jan 26, 2017
@rybesh
Copy link
Member

rybesh commented Jan 26, 2017

@atomrab Can I conclude from this discussion that we officially do not require a value for spatialCoverageDescription? If so, I will close this bug and make this clear in the data model documentation and change policy.

@atomrab
Copy link

atomrab commented Jan 26, 2017 via email

@rybesh
Copy link
Member

rybesh commented Jan 26, 2017

I was thinking that it would be fine to not require this (but we should require at least one spatial entity to be specified; see issue #34). Why is the "undefined" value in the filter annoying?

@atomrab
Copy link

atomrab commented Jan 26, 2017 via email

@rybesh
Copy link
Member

rybesh commented Feb 6, 2017

This is a client issue, see periodo/periodo-client#120

@rybesh rybesh added the wontfix label Feb 6, 2017
@rybesh rybesh closed this as completed Feb 6, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants