Update github actions #3
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for this @yewtc! I'm going to close and re-open to kick off a CI build. |
I'm actually not sure why that warning occurs. It's quite noisy, though. 😞 |
|
We've got a 5.38 failure here. |
|
See issue #4 - there's a change in perl behaviour starting with 5.37. I was going to fix the tests, but as per the issue, I'm not sure if fixing the tests to make them pass is the correct solution. Any fix needs to be thought through. I'm not sure that it isn't a perl bug. |
|
Right. I guess it's related to houseabsolute/p5-Test-Vars#47 and also Perl/perl5#20114 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was assigned this repo as part of the pull request club. I'm going to actually do 2 pull requests. This one is a "meta" the "meta" pull request. Mainly updating the github actions to be current versions, to remove some warnings. I had to do a perltidy - on script/perlvars and App/perlvars.pm - which I don't understand, but anyway it was needed. I also added the work flow dispatch option to enable running from within github. There is still a warning, but that is from perl-actions/install-with-cpm@v1 about set-output. I mention it here as I see that you are one of contributors to that repo and there is an open issue for it.