Rework tests to skip files after the files are selected

not only if we're picking the default files; allows us to
not care if we pass in a bunch of inappropriate files for a
test with TEST_FILES

Author: coke

t/pod-valid.t

@@ -17,12 +17,10 @@ if @*ARGS {
     if %*ENV<TEST_FILES> {
         @files = %*ENV<TEST_FILES>.split(',');
     } else {
-        for qx<git ls-files>.lines -> $file {
-            next unless $file ~~ / '.pod6' $/;
-            push @files, $file;
-        }
+        @files = qx<git ls-files>.lines;
     }
 }
+@files = @files.grep(/'.pod6'$/);
 
 plan +@files;
 

t/tabs.t

@@ -10,17 +10,14 @@ if @*ARGS {
     if %*ENV<TEST_FILES> {
         @files = %*ENV<TEST_FILES>.split(',');
     } else {
-        for qx<git ls-files>.lines -> $file {
-            next if $file eq "LICENSE"|"Makefile";
-            next if $file ~~ / 'custom-theme'/;
-            next if $file ~~ / 'jquery'/;
-            next if $file ~~ / '.png' $/;
-            next if $file ~~ / '.ico' $/;
-        
-            push @files, $file;
-        }
+        @files = qx<git ls-files>.lines;
     }
 }
+@files = @files.grep({$_ ne 'LICENSE'|'Makefile'})\
+               .grep({! $_.contains('custom-theme')})\
+               .grep({! $_.contains('jquery')})\
+               .grep({! $_.ends-with('.png')})\
+               .grep({! $_.ends-with('.ico')});
 
 plan +@files;
 

xt/aspell.t

@@ -25,14 +25,13 @@ if @*ARGS {
     if %*ENV<TEST_FILES> {
         @files = %*ENV<TEST_FILES>.split(',');
     } else {
-        for qx<git ls-files>.lines -> $file {
-            next unless $file ~~ / '.' ('pod6'|'md') $/;
-            next if $file ~~ / 'contributors.pod6' $/; # names are hard.
-            push @files, $file;
-        }
+        @files = qx<git ls-files>.lines;
     }
 }
 
+@files = @files.grep({$_.ends-with('.pod6') or $_.ends-with('.md')})\
+               .grep({! $_.ends-with('contributors.pod6')});
+
 plan +@files;
 my $max-jobs = %*ENV<TEST_THREADS> // 2;
 

xt/duplicates.t

@@ -24,12 +24,10 @@ if @*ARGS {
     if %*ENV<TEST_FILES> {
         @files = %*ENV<TEST_FILES>.split(',');
     } else {
-        for qx<git ls-files>.lines -> $file {
-            next unless $file ~~ / '.' ('pod6'|'md') $/;
-            push @files, $file;
-        }
+        @files = qx<git ls-files>.lines;
     }
 }
+@files = @files.grep({$_.ends-with('.pod6') or $_.ends-with('.md')});
 
 plan +@files;
 

xt/examples-compilation.t

@@ -25,13 +25,12 @@ if @*ARGS {
     if %*ENV<TEST_FILES> {
         @files = %*ENV<TEST_FILES>.split(',');
     } else { 
-        for qx<git ls-files doc>.lines -> $file {
-            next unless $file ~~ / '.pod6' $/;
-            push @files, $file;
-        }
+        @files = qx<git ls-files doc>.lines;
     }
 }
 
+@files = @files.grep({$_.ends-with('.pod6')});
+
 sub walk($arg) {
     given $arg {
         when Pod::FormattingCode { walk $arg.contents }

xt/perl-nbsp.t

@@ -9,13 +9,12 @@ if @*ARGS {
     if %*ENV<TEST_FILES> {
         @files = %*ENV<TEST_FILES>.split(',');
     } else {
-        for qx<git ls-files>.lines -> $file {
-            next unless $file ~~ / '.pod6' $/;
-            push @files, $file;
-        }
+        @files = qx<git ls-files doc>.lines;
     }
 }
 
+@files = @files.grep({$_.ends-with('.pod6')});
+
 plan +@files;
 
 for @files.sort -> $file {

xt/return-type.t

@@ -12,10 +12,12 @@ if @*ARGS {
     if %*ENV<TEST_FILES> {
         @files = %*ENV<TEST_FILES>.split(',');
     } else {
-        @files = qx<git ls-files>.lines.grep(* ~~ /'.pod6'/).grep(* ~~ /Type | Language/);
+        @files = qx<git ls-files>.lines;
     }
 }
 
+@files = @files.grep(* ~~ /'.pod6'/).grep(* ~~ /Type | Language/);
+
 plan +@files;
 
 for @files -> $file {

xt/space-after-comma.t

@@ -16,14 +16,13 @@ if @*ARGS {
     if %*ENV<TEST_FILES> {
         @files = %*ENV<TEST_FILES>.split(',');
     } else {
-        for qx<git ls-files>.lines -> $file {
-            next unless $file ~~ / '.' ('pod6'|'md') $/;
-            next if $file ~~ / 'contributors.pod6' $/; # names are hard.
-            push @files, $file;
-        }
+        @files = qx<git ls-files>.lines;
     }
 }
 
+@files = @files.grep({$_.ends-with('.pod6') or $_.ends-with('.md')})\
+               .grep({! $_.ends-with('contributors.pod6')});
+
 plan +@files;
 my $max-jobs = %*ENV<TEST_THREADS> // 2;
 my %output;

xt/trailing-whitespace.t

@@ -10,19 +10,17 @@ if @*ARGS {
     if %*ENV<TEST_FILES> {
         @files = %*ENV<TEST_FILES>.split(',');
     } else {
-        for qx<git ls-files>.lines -> $file {
-            next if $file eq "LICENSE"|"Makefile";
-            next if $file ~~ / 'custom-theme'/;
-            next if $file ~~ / 'jquery'/;
-            next if $file ~~ / '.png' $/;
-            next if $file ~~ / '.ico' $/;
-            next if $file ~~ / 'util/trigger-rebuild.txt' /;
-        
-            push @files, $file;
-        }
+        @files = qx<git ls-files>.lines;
     }
 }
 
+@files = @files.grep({$_ ne 'LICENSE'|'Makefile'})\
+               .grep({! $_.contains('custom-theme')})\
+               .grep({! $_.contains('util/trigger-rebuild.txt')})\
+               .grep({! $_.contains('jquery')})\
+               .grep({! $_.ends-with('.png')})\
+               .grep({! $_.ends-with('.ico')});
+
 plan +@files;
 
 for @files -> $file {