Style cleanup. #1154
Merged
Style cleanup. #1154
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mostly style updates.
Not all feedback has been implemented.
Not all feedback has been implemented.
AlexDaniel
approved these changes
Jan 23, 2017
|
It seems good for me, +1 for merging. |
|
Go for it |
jonathanstowe
approved these changes
Jan 23, 2017
|
Will get to this sometime today. Most looks fine. Thanks. |
|
In future, lets make sure merges like this pass 'make xtest' - several new failures here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please use whatever you like. Thanks.
I closed the other pull requests since there was an issue with rebasing.