Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proc::Async example with 「react」 #1489

Merged
merged 3 commits into from Sep 2, 2017
Merged

Proc::Async example with 「react」 #1489

merged 3 commits into from Sep 2, 2017

Conversation

AlexDaniel
Copy link
Member

@AlexDaniel AlexDaniel commented Sep 2, 2017

Tackle issue #1468.

IMO in this case it is reasonable to expect that people will be
copying the example and reducing it to their needs, so I tried to
include everything that may be needed.

The logic for kill signals is questionable, I don't know if there's
anything better we can show.

This is not mergeable because of RT #132016. Either wait for the
ticket to be resolved or get rid of 「Supply.merge」 and 「Supply.zip」.

Tackle issue #1468.

IMO in this case it is reasonable to expect that people will be
copying the example and reducing it to their needs, so I tried to
include everything that may be needed.

The logic for kill signals is questionable, I don't know if there's
anything better we can show.

This is not mergeable because of RT #132016. Either wait for the
ticket to be resolved or get rid of 「Supply.merge」 and 「Supply.zip」.
@jonathanstowe
Copy link
Contributor

Not a thing on this PR but It occurs to me that there probably isn't an example of react with a variety of dissimilar supplies like this (or even more complex,) perhaps something fpr the concurrency page?

@moritz moritz merged commit fb916ea into master Sep 2, 2017
@AlexDaniel AlexDaniel deleted the procreact branch September 2, 2017 23:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants