Modify Dockerfile and Add Docker-related Make targets #1637
Conversation
Made a number of modifications to the Dockerfile in the repo:
* Minimized the number of cache layers in final image (by reducing the
number of Run commands)
* This way Docker will not reuse cache layers containing outdated
package versions.
* Purge build dependencies and apt cache data.
* These files do not appear in final image due to minimal intermediate
cache layers.
* The resulting image is over 100 MB smaller as a result.
* Update NodeJS to the latest stable release via the
[n](https://github.com/tj/n) script.
* Added Test::META module and GNU aspell (used in tests).
Also added a .dockerignore file, so that files within the repo do not
get used in the build context.
Add targets that make the Docker containers a bit easier to work with. Add info to CONTRIBUTING indicating how to use these targets.
|
I didn't want to commit something like this to the repo without either some review or the approval of other members and/or owners. This greatly modifies the existing Dockerfile (what and why in description) in the repo and introduces a number of new targets to the Makefile. |
|
This looks reasonable to me, though I'm by no means a Docker expert. |
|
I'm no expert either. It's functional, but there may be better ways of doing things. More than anything though, I just don't want to be committing things other members don't want or don't agree with. If the general consensus is people are okay with this, I will gladly commit it. Thanks for your feedback. |
|
@7ojo you committed the original Dockerfile. Any objections? |
|
No objections! Seems fine to me 👍 Using Makefile simplifies things nicely if you're not so familiar with docker |
Made a number of modifications to the Dockerfile in the repo:
number of Run commands)
package versions.
cache layers.
n script.
Also added a .dockerignore file, so that files within the repo do not
get used in the build context.
Added Make targets that make the Docker containers a bit easier to work with.
Add info to CONTRIBUTING indicating how to use these targets.