Google search option #2171
Merged
Google search option #2171
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 Thanks! |
I sent you an invite to perl6 GitHub org. You can accept it here https://github.com/perl6/ and commit any further changes you wanted to make directly. |
|
Thanks. I did change the no-results text to "try site search". I'll close #1391 as well. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The problem
Issue #1391 describes a desire to always have a google search option in the search autocomplete menu, not just when there are no results.
Solution provided
In the _renderMenu function of search_template.js, a new menu item is added after all other items are sorted. It uses a new category of "Site Search", and contains a link to a google search for the current keywords. See screenshot.
If the wording of the category and menu item is deemed appropriate, we might consider changing the no-results text from "try web search" to "try site search" to be consistent.
I did not see any existing tests for the search autocomplete menu, so there are no tests to accompany this change.