Skip to content

Conversation

ZzZombo
Copy link
Contributor

@ZzZombo ZzZombo commented Aug 22, 2018

Reverts #2274

See the discussion.

@ZzZombo ZzZombo merged commit ed1df4c into master Aug 22, 2018
@ZzZombo ZzZombo deleted the revert-2274-patch-1 branch August 22, 2018 08:07
Copy link
Contributor

@JJ JJ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code was changed to printing the @b variable, such as you said in your comment. What's the problem?
Also, "same thing" does not mean anything at all and may be confusing. So all changes have a a point. Why revert it?

@JJ
Copy link
Contributor

JJ commented Aug 22, 2018

Besides, now the code is wrong, such as it was at the beginning. It prints the "same thing" because, well, it's the same thing (the @a variable). Can you please clarify?

@ZzZombo
Copy link
Contributor Author

ZzZombo commented Aug 22, 2018

Huh, I apologize deeply. I swear I didn't see the another commit somehow. So it looked like you blindly merged the original PR, so I went ahead and reverted it. What a mess.

ZzZombo added a commit that referenced this pull request Aug 22, 2018
@JJ
Copy link
Contributor

JJ commented Aug 22, 2018

No problem :-)

ZzZombo added a commit that referenced this pull request Aug 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants