Rewrite of Syntax-Identifier section #2336
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JJ
requested changes
Sep 29, 2018
doc/Language/syntax.pod6
Outdated
| for more details. | ||
| In the C<x²> example above, since the Unicode superscript numeral C<²> is not | ||
| alphanumeric, it cannot be a part of an ordinary identifier. Still, it may form | ||
| part of a valid expression as an operator. The expression C<$x²>, for instance, |
There was a problem hiding this comment.
As long as it's clear it's not alphanumeric, the rest of the paragraph is probably not needed in a section about identifiers, not even as a teaser for the other section
There was a problem hiding this comment.
And since it is the first comment, I would really have appreciated if you had not closed the other PR, added new commits addressing (or not) my comments, which you apparently have to a extent. Please do so this time; just push new commits, and comment responding to these comments.
doc/Language/syntax.pod6
Outdated
| party:$a # ...or $a | ||
| =end code | ||
| N<As the examples illustrate, the C<key> I<or> the quoted C<value> is optional. | ||
| Colon pairs with a null key are normally used for naming operators, as |
There was a problem hiding this comment.
You should have said so in the description above.
JJ
reviewed
Oct 3, 2018
JJ
requested changes
Oct 3, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The problem
Identifier-section was perceived as a bit messy.
Solution provided
Restructured section along the lines of the different types of identifiers: