Pursue .WHAT removal #3074
Merged
Pursue .WHAT removal #3074
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Sync output with code example - Update code example description - Advise .^name usage
jnthn
reviewed
Oct 25, 2019
| =end code | ||
|
|
||
| The first two tests each smartmatch against a class name. If the object is | ||
| of that class, or of an inheriting class, it returns true. So the object in | ||
| question is of class C<Employee> or one that inherits from it, but not | ||
| C<GeekCook>. | ||
|
|
||
| The C<.WHAT> method returns the type object associated with the object | ||
| C<$o>, which tells us the exact type of C<$o>: in this case C<Programmer>. | ||
| The call C<$o.^name> tells us the type of C<$o>: in this case C<Programmer>. |
There was a problem hiding this comment.
I think here it's useful to mention both of them.
There was a problem hiding this comment.
@jnth The code doesn't use .WHAT so that's why the output and the description are being tweaked, I think you mean that we should revert the original commit?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The problem
.WHAT was removed from an example in snippet in doc/Language/classtut.pod6 a year ago in favor of .^name: this is a followup