Skip to content

Conversation

Altai-man
Copy link
Member

@Altai-man Altai-man commented Jul 27, 2016

Smooth css animation for TOC. This animation isn't based on (max-)height. The only JS part needed is to change css classes, should work with most browsers.

@Altai-man
Copy link
Member Author

Fixes #686

@Altai-man
Copy link
Member Author

We still need two classes for animation, since if we remove one, hiding or showing will be without animation transition.

@Altai-man Altai-man merged commit 60aa1dd into master Jul 27, 2016
@Altai-man Altai-man deleted the animated_css branch July 27, 2016 18:39
@AlexDaniel
Copy link
Member

But, but… it does not work at all! It seems like .css file was not generated or something.

@Altai-man
Copy link
Member Author

It was fixed. I thought the server builds sass-files by itself.

@zoffixznet
Copy link
Contributor

zoffixznet commented Jul 27, 2016

@AlexDaniel which browser?

In my Firefox the failure modes are:

  1. The text disappears, but the height of the table is still there, so the entire point of hiding the ToC is broken; I still have to scroll (this is on small-width view, where the ToC is at the top of the page)
  2. After I hide the ToC, on page load the ToC flashes in shown position and then animates to an off position. It should start off in off position

@zoffixznet
Copy link
Contributor

zoffixznet commented Jul 27, 2016

I thought the server builds sass-files by itself.

Not yet. It just uses the generated html/css/style.css file.

@coke
Copy link
Collaborator

coke commented Jul 28, 2016

I have the same issue as @zoffixznet - the text hides, but the vertical space it consumes is still there, and the default on page reload is wrong.

Please revert this for now.

@Altai-man
Copy link
Member Author

Reverted. I suppose, we should just remove animation at all then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants