[js] NaN is true in nqp

pmurias · pmurias · commit 3909a4823d56 · 2017-09-21T14:05:25.000+02:00
diff --git a/src/vm/js/Compiler.nqp b/src/vm/js/Compiler.nqp
@@ -598,8 +598,10 @@ class QAST::CompilerJS does DWIMYNameMangling does SerializeOnce {
             }
 
             if $desired == $T_BOOL {
-                if $got == $T_INT || $got == $T_NUM {
+                if $got == $T_INT {
                     return Chunk.new($T_BOOL, $chunk.expr, $chunk);
+                } elsif $got == $T_NUM {
+                    return Chunk.new($T_BOOL, "({$chunk.expr} !== 0)", $chunk);
                 } elsif $got == $T_STR {
                     return Chunk.new($T_BOOL, "({$chunk.expr} && {$chunk.expr} !== nqp.null_s)", $chunk);
                 }

Original file line number	Diff line number	Diff line change
`@@ -598,8 +598,10 @@ class QAST::CompilerJS does DWIMYNameMangling does SerializeOnce {`
`598`	`598`	`}`
`599`	`599`
`600`	`600`	`if $desired == $T_BOOL {`
`601`		`- if $got == $T_INT \|\| $got == $T_NUM {`
	`601`	`+ if $got == $T_INT {`
`602`	`602`	`return Chunk.new($T_BOOL, $chunk.expr, $chunk);`
	`603`	`+ } elsif $got == $T_NUM {`
	`604`	`+ return Chunk.new($T_BOOL, "({$chunk.expr} !== 0)", $chunk);`
`603`	`605`	`} elsif $got == $T_STR {`
`604`	`606`	`return Chunk.new($T_BOOL, "({$chunk.expr} && {$chunk.expr} !== nqp.null_s)", $chunk);`
`605`	`607`	`}`