Skip to content

Commit 3bde5a3

Browse files
committed
Remove some TODOs since they weren't actually necessary. jnthn++
1 parent 6700db0 commit 3bde5a3

File tree

1 file changed

+0
-13
lines changed

1 file changed

+0
-13
lines changed

src/6model/reprs/CStruct.c

Lines changed: 0 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -5,8 +5,6 @@
55
#include "CStruct.h"
66

77
/* TODO:
8-
* - The initialize_slots member in the REPRData needs to be more complex
9-
* - So that we can handle initialisation of member objects as well as numbers
108
* - We need to handle setting and getting non-number members. In particular,
119
* setting an object member needs to not only update the child_obj pointer,
1210
* but also set the pointer in the cstruct part.
@@ -223,18 +221,7 @@ static void compute_allocation_strategy(PARROT_INTERP, PMC *WHAT, CStructREPRDat
223221
}
224222
else if(STRING_equal(interp, REPR(type)->name, carray_str)) {
225223
/* It's a CArray of some kind. */
226-
227224
repr_data->num_child_objs++;
228-
if (REPR(type)->initialize) {
229-
/* Copy-pasta of what happens in the flattening case.
230-
* initialize_slots probably needs to be a list of
231-
* something more complex to handle objects as well,
232-
* though.
233-
if (!repr_data->initialize_slots)
234-
repr_data->initialize_slots = (INTVAL *) mem_sys_allocate_zeroed((info_alloc + 1) * sizeof(INTVAL));
235-
repr_data->initialize_slots[cur_init_slot] = i;
236-
cur_init_slot++;*/
237-
}
238225
}
239226
else {
240227
Parrot_ex_throw_from_c_args(interp, NULL, EXCEPTION_INVALID_OPERATION,

0 commit comments

Comments
 (0)