Convert substr+eq to eqat

nqp::eqat is much faster than doing a substr+eq.

Author: MasterDuke17

src/HLL/CommandLine.nqp

@@ -171,13 +171,12 @@ class HLL::CommandLine::Parser {
 
     method is-option($x) {
         return 0 if $x eq '-' || $x eq '--';
-        return 1 if nqp::substr($x, 0, 1) eq '-';
-        0;
+        nqp::eqat($x, '-', 0);
     }
 
     method wants-value($x) {
         my $spec := %!options{$x};
-        nqp::substr($spec, 0, 1) eq 's';
+        nqp::eqat($spec, 's', 0);
     }
 
     method optional-value($x) {
@@ -215,7 +214,7 @@ class HLL::CommandLine::Parser {
         while $i < $arg-count {
             my $cur := @args[$i];
             if self.is-option($cur) {
-                if nqp::substr($cur, 0, 2) eq '--' {
+                if nqp::eqat($cur, '--', 0) {
                     # long option
                     my $opt := nqp::substr(@args[$i], 2);
                     my $idx := nqp::index($opt, '=');

src/HLL/Compiler.nqp

@@ -105,7 +105,7 @@ class HLL::Compiler does HLL::Backend::Default {
                 if self.input-incomplete($output) {
                     # Need to get more code before we execute
                     # Strip the trailing \, but reinstate the newline
-                    if nqp::substr($code, 0, nqp::chars($code) - 2) eq "\\\n" {
+                    if nqp::eqat($code, "\\\n", 0) {
                         $code := nqp::substr($code, 0, nqp::chars($code) - 2) ~ "\n";
                     }
                     if $code {
@@ -153,7 +153,7 @@ class HLL::Compiler does HLL::Backend::Default {
     method eval($code, *@args, *%adverbs) {
         my $output;
 
-        if $code && nqp::substr($code, nqp::chars($code) - 2) eq "\\\n" {
+        if $code && nqp::eqat($code, "\\\n", nqp::chars($code) - 2) {
             return self.needs-more-input();
         }
 
@@ -650,7 +650,7 @@ class HLL::Compiler does HLL::Backend::Default {
                 # Treat \r\n as a single logical newline. Note that NFG
                 # implementations, we should check it really is a lone \r,
                 # not the first bit of a \r\n grapheme.
-                if nqp::iseq_i($ord, 13) && nqp::substr($s, $jpos - 1, 1) eq "\r" &&
+                if nqp::iseq_i($ord, 13) && nqp::eqat($s, "\r", $jpos - 1) &&
                    $jpos < $eos && nqp::iseq_i(nqp::ord($s, $jpos), 10)
                 {
                     $jpos := nqp::add_i($jpos, 1);

src/HLL/Grammar.nqp

@@ -273,7 +273,7 @@ position C<pos>.
 
             # see if the opening bracket is repeated
             my int $len := 1;
-            while nqp::substr($target, ++$pos, 1) eq $start {
+            while nqp::eqat($target, $start, ++$pos) {
                 $len++;
             }
             if $len > 1 {

src/HLL/sprintf.nqp

@@ -237,7 +237,7 @@ my module sprintf {
         sub normalize($float) {
             my @parts := nqp::split('e', nqp::lc($float));
             my $sign := '';
-            if nqp::substr(@parts[0],0,1) eq '-' {
+            if nqp::eqat(@parts[0], '-', 0) {
                 $sign := '-';
                 @parts[0] := nqp::substr(@parts[0], 1);
             }
@@ -271,7 +271,7 @@ my module sprintf {
 
             my $zeroes := infix_x("0", 1 + ($precision > $d ?? $precision - $d  !! 0));
 
-            $lhs_s := nqp::substr($lhs_s, 1) if nqp::substr($lhs_s, 0, 1) eq '-';
+            $lhs_s := nqp::substr($lhs_s, 1) if nqp::eqat($lhs_s, '-', 0);
             my $lhs_I := nqp::fromstr_I($lhs_s, $knowhow);
             my $rhs_I := nqp::fromstr_I("1" ~ $rhs_s ~ $zeroes, $knowhow);      # The leading 1 is to preserve leading zeroes
             my $cc := nqp::chars(nqp::tostr_I($rhs_I));

src/NQP/Actions.nqp

@@ -1494,7 +1494,7 @@ class NQP::Actions is HLL::Actions {
                 $ast[$i] := $ast[$i][0];
                 $ast[$i].flat(1);
                 $ast[$i].named(1) if nqp::istype($ast[$i], QAST::Var)
-                    && nqp::substr($ast[$i].name, 0, 1) eq '%';
+                    && nqp::eqat($ast[$i].name, '%', 0);
             }
             $i++;
         }

src/NQP/Optimizer.nqp

@@ -137,7 +137,7 @@ class NQP::Optimizer {
         self.visit_children($block);
 
         # Methods with late-bound names poison lowering.
-        if nqp::substr($block.name, 0, 12) eq '!!LATENAME!!' {
+        if nqp::eqat($block.name, '!!LATENAME!!', 0) {
             self.poison_lowering();
         }
 

src/QRegex/Cursor.nqp

@@ -854,8 +854,16 @@ role NQPMatchRole is export {
             my int $litlen := nqp::chars($str);
             my str $target := nqp::getattr_s($!shared, ParseShared, '$!target');
             if $litlen < 1 ||
+#?if jvm
                 ($i ?? nqp::lc(nqp::substr($target, $!pos, $litlen)) eq nqp::lc($str)
-                    !! nqp::substr($target, $!pos, $litlen) eq $str) {
+#?endif
+#?if js
+                ($i ?? nqp::lc(nqp::substr($target, $!pos, $litlen)) eq nqp::lc($str)
+#?endif
+#?if moar
+                ($i ?? nqp::eqatic($target, $str, $!pos)
+#?endif
+                    !! nqp::eqat($target, $str, $!pos)) {
                 my $cur := self."!cursor_start_cur"();
                 $cur."!cursor_pass"($!pos + $litlen);
                 $cur
@@ -1300,7 +1308,7 @@ class NQPMatch is NQPCapture does NQPMatchRole {
                 else {
                     my int $len := nqp::chars($_);
                     $maxlen     := $len if $len > $maxlen && $pos + $len <= $eos
-                        && nqp::substr($tgt, $pos, $len) eq $_;
+                        && nqp::eqat($tgt, $_, $pos);
                 }
                 last if $s && $maxlen > -1;
             }

src/how/NQPClassHOW.nqp

@@ -782,7 +782,7 @@ knowhow NQPClassHOW {
         }
     }
     method should_trace($obj, $name) {
-        return 0 if nqp::substr($name, 0, 1) eq '!';
+        return 0 if nqp::eqat($name, '!', 0);
         for @!trace_exclude {
             return 0 if $name eq $_;
         }

src/how/NQPParametricRoleHOW.nqp

@@ -143,7 +143,7 @@ knowhow NQPParametricRoleHOW {
             my $meth := nqp::can(nqp::iterval($_), 'instantiate_generic')
                 ?? nqp::iterval($_).instantiate_generic($pad)
                 !! nqp::iterval($_).clone();
-            if nqp::substr($name, 0, 12) eq '!!LATENAME!!' {
+            if nqp::eqat($name, '!!LATENAME!!', 0) {
                 $name := nqp::atkey($pad, nqp::substr($name, 12));
                 $meth.'!set_name'($name);
             }

src/vm/moar/HLL/Backend.nqp

@@ -85,8 +85,8 @@ class HLL::Backend::MoarVM {
         }
         nqp::sayfh(nqp::getstderr(), "Writing profiler output to $filename");
         my $profile_fh := open($filename, :w);
-        my $want_json  := nqp::substr($filename, -5) eq '.json';
-        my $want_sql   := nqp::substr($filename, -4) eq '.sql';
+        my $want_json  := nqp::eqat($filename, '.json', -5);
+        my $want_sql   := nqp::eqat($filename, '.sql', -4);
 
         my $escaped_backslash;
         my $escaped_dquote;