Write barriering in reprs, plus a re-ordering just in case that triggers an issue.

Author: jnthn

src/6model/reprs/HashAttrStore.c

@@ -20,8 +20,9 @@ static PMC * type_object_for(PARROT_INTERP, PMC *self, PMC *HOW) {
 
     /* Create type object and point it back at the STable. We leave the
      * hash store pointer null to flag it's the type object. */
-    st->WHAT = wrap_object(interp, obj);
     obj->common.stable = st_pmc;
+    st->WHAT = wrap_object(interp, obj);
+    PARROT_GC_WRITE_BARRIER(interp, st_pmc);
 
     return st->WHAT;
 }

src/6model/reprs/KnowHOWREPR.c

@@ -19,8 +19,9 @@ static PMC * type_object_for(PARROT_INTERP, PMC *self, PMC *HOW) {
     STable *st  = STABLE_STRUCT(st_pmc);
 
     /* Create type object and point it back at the STable. */
-    st->WHAT = wrap_object(interp, obj);
     obj->common.stable = st_pmc;
+    st->WHAT = wrap_object(interp, obj);
+    PARROT_GC_WRITE_BARRIER(interp, st_pmc);
 
     return st->WHAT;
 }

src/6model/reprs/P6int.c

@@ -18,8 +18,9 @@ static PMC * type_object_for(PARROT_INTERP, PMC *self, PMC *HOW) {
     STable *st  = STABLE_STRUCT(st_pmc);
 
     /* Create type object and point it back at the STable. */
-    st->WHAT = wrap_object(interp, obj);
     obj->common.stable = st_pmc;
+    st->WHAT = wrap_object(interp, obj);
+    PARROT_GC_WRITE_BARRIER(interp, st_pmc);
 
     return st->WHAT;
 }

src/6model/reprs/P6num.c

@@ -18,8 +18,9 @@ static PMC * type_object_for(PARROT_INTERP, PMC *self, PMC *HOW) {
     STable *st  = STABLE_STRUCT(st_pmc);
 
     /* Create type object and point it back at the STable. */
-    st->WHAT = wrap_object(interp, obj);
     obj->common.stable = st_pmc;
+    st->WHAT = wrap_object(interp, obj);
+    PARROT_GC_WRITE_BARRIER(interp, st_pmc);
 
     return st->WHAT;
 }

src/6model/reprs/P6opaque.c

@@ -340,8 +340,9 @@ static PMC * type_object_for(PARROT_INTERP, PMC *self, PMC *HOW) {
      * do *not* populate the spill pointer at all, we leave it null. A
      * non-null value (even PMCNULL) is what indicates we have a defined
      * object. Yes, I know, it's sick. */
-    st->WHAT = wrap_object(interp, obj);
     obj->common.stable = st_pmc;
+    st->WHAT = wrap_object(interp, obj);
+    PARROT_GC_WRITE_BARRIER(interp, st_pmc);
 
     return st->WHAT;
 }

src/6model/reprs/P6str.c

@@ -18,8 +18,9 @@ static PMC * type_object_for(PARROT_INTERP, PMC *self, PMC *HOW) {
     STable *st  = STABLE_STRUCT(st_pmc);
 
     /* Create type object and point it back at the STable. */
-    st->WHAT = wrap_object(interp, obj);
     obj->common.stable = st_pmc;
+    st->WHAT = wrap_object(interp, obj);
+    PARROT_GC_WRITE_BARRIER(interp, st_pmc);
 
     return st->WHAT;
 }