Improved diagnostics for Parrot Object types sneaking into places that need serialization.

jnthn · jnthn · commit 9acb660b0af7 · 2012-02-26T16:06:09.000+01:00
diff --git a/src/6model/serialization.c b/src/6model/serialization.c
@@ -448,6 +448,11 @@ void write_ref_func(PARROT_INTERP, SerializationWriter *writer, PMC *ref) {
             discrim = REFVAR_CLONED_CODEREF;
         }
     }
+    else if (ref->vtable->base_type == enum_class_Object) {
+        Parrot_ex_throw_from_c_args(interp, NULL, EXCEPTION_INVALID_OPERATION,
+            "Serialization Error: Parrot object type '%Ss' passed to write_ref",
+            VTABLE_name(interp, VTABLE_get_class(interp, ref)));
+    }
     else {
         Parrot_ex_throw_from_c_args(interp, NULL, EXCEPTION_INVALID_OPERATION,
             "Serialization Error: Unimplemented object type '%Ss' passed to write_ref",

Original file line number	Diff line number	Diff line change
`@@ -448,6 +448,11 @@ void write_ref_func(PARROT_INTERP, SerializationWriter writer, PMC ref) {`
`448`	`448`	`discrim = REFVAR_CLONED_CODEREF;`
`449`	`449`	`}`
`450`	`450`	`}`
	`451`	`+ else if (ref->vtable->base_type == enum_class_Object) {`
	`452`	`+ Parrot_ex_throw_from_c_args(interp, NULL, EXCEPTION_INVALID_OPERATION,`
	`453`	`+ "Serialization Error: Parrot object type '%Ss' passed to write_ref",`
	`454`	`+ VTABLE_name(interp, VTABLE_get_class(interp, ref)));`
	`455`	`+ }`
`451`	`456`	`else {`
`452`	`457`	`Parrot_ex_throw_from_c_args(interp, NULL, EXCEPTION_INVALID_OPERATION,`
`453`	`458`	`"Serialization Error: Unimplemented object type '%Ss' passed to write_ref",`