Skip to content

Add my name to the list #82

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 8, 2019
Merged

Add my name to the list #82

merged 1 commit into from
Aug 8, 2019

Conversation

FCO
Copy link
Contributor

@FCO FCO commented Aug 8, 2019

No description provided.

@AlexDaniel AlexDaniel self-assigned this Aug 8, 2019
@AlexDaniel AlexDaniel added the meta Changes to this repo and the main document label Aug 8, 2019
@AlexDaniel
Copy link
Member

FCO has been around for a long time and is working on some relatively important projects like Red.

I think we're a bit past the point when it was possible to add people to the list without the review process, so we'll be doing that from now on.

Ping @AlexDaniel @JJ @jnthn @lizmat @maettu @masak @MasterDuke17 @moritz @rba @samcv @timo @tony-o @ugexe.

@AlexDaniel AlexDaniel mentioned this pull request Aug 8, 2019
Closed
@JJ JJ merged commit 1b4a81e into Raku:master Aug 8, 2019
@AlexDaniel
Copy link
Member

AlexDaniel commented Aug 8, 2019 •
edited
Loading

@JJ I guess that was a misclick. We'll try to do the things right, so it needs a review from everyone. Not that this PR is not controversial by any means, but let's not set a precedent that you can change something like this without waiting for everyone.

AlexDaniel added a commit that referenced this pull request Aug 8, 2019
@AlexDaniel
Revert "Merge pull request #82 from FCO/patch-1"
4c72730 
This reverts commit 1b4a81e, reversing
changes made to 164f37f.
@AlexDaniel AlexDaniel mentioned this pull request Aug 8, 2019
Merged
@AlexDaniel
Copy link
Member

Please add your reviews again here: #84. This PR was merged by mistake which should no longer happen because there's now a requirement to have enough reviews that is enforced by github features.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JJ JJ JJ approved these changes

@moritz moritz moritz approved these changes

@lizmat lizmat lizmat approved these changes

@jnthn jnthn Awaiting requested review from jnthn

@maettu maettu Awaiting requested review from maettu

@masak masak Awaiting requested review from masak

@MasterDuke17 MasterDuke17 Awaiting requested review from MasterDuke17

@rba rba Awaiting requested review from rba

@samcv samcv Awaiting requested review from samcv

@timo timo Awaiting requested review from timo

@tony-o tony-o Awaiting requested review from tony-o

@ugexe ugexe Awaiting requested review from ugexe

+1 more reviewer

@AlexDaniel AlexDaniel AlexDaniel approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@AlexDaniel AlexDaniel

Labels
meta Changes to this repo and the main document
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@FCO @AlexDaniel @JJ @moritz @lizmat