Add a TODO note about kill signals

AlexDaniel · AlexDaniel · commit 1bf72b5e60cc · 2016-08-08T08:11:21.000+03:00
diff --git a/Whateverable.pm6 b/Whateverable.pm6
@@ -68,7 +68,7 @@ method get-output(*@run-args, :$timeout = $!timeout) {
     my $s-end = now;
 
     if not $promise.status ~~ Kept { # timed out
-        $proc.kill;
+        $proc.kill; # TODO sends HUP, but should kill the process tree instead
         @out.unshift: “«timed out after $timeout seconds, output»: ”;
     }
     return (@out.join.chomp, $promise.result.exitcode, $promise.result.signal, $s-end - $s-start)

Original file line number	Diff line number	Diff line change
`@@ -68,7 +68,7 @@ method get-output(*@run-args, :$timeout = $!timeout) {`
`68`	`68`	`my $s-end = now;`
`69`	`69`
`70`	`70`	`if not $promise.status ~~ Kept { # timed out`
`71`		`- $proc.kill;`
	`71`	`+ $proc.kill; # TODO sends HUP, but should kill the process tree instead`
`72`	`72`	`@out.unshift: “«timed out after $timeout seconds, output»: ”;`
`73`	`73`	`}`
`74`	`74`	`return (@out.join.chomp, $promise.result.exitcode, $promise.result.signal, $s-end - $s-start)`