Skip to content

Conversation

missinglink
Copy link
Contributor

@missinglink missinglink commented Jun 2, 2025

  • standardize bbox param
  • simplify parser logic
  • update types

'point.lon': location.lng
});
const data = await getJSON<any>(this.options.serviceUrl + '/reverse', params);
return this._parseResults(data, 'bounds');
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't recall the history of this but the bbox param isn't named bounds, someone has put effort into supporting alternative key names and I'm not sure why 🤷

@missinglink missinglink marked this pull request as ready for review June 2, 2025 13:54
@missinglink
Copy link
Contributor Author

I think this looks good, @perliedman anything else which needs cleaning up while I'm at it?

If you'd like a production key for testing/whatever you can grab one from https://geocode.earth if you'd like to have it longer than the free trial just email me and I'll convert it to a forever trial.

@missinglink missinglink force-pushed the pelias branch 6 times, most recently from 8badec1 to 8e79901 Compare June 2, 2025 21:09
@perliedman
Copy link
Owner

Hi @missinglink ! Thanks for taking the time to contribute this. Unfortunately, although I'm technically the owner of this repository, I haven't touched the code in many, many years, so I'm reluctant to review or merge anything.

@missinglink
Copy link
Contributor Author

missinglink commented Aug 9, 2025

Hi @perliedman, ugh ok, @simon04 said he'd be happy to accept this in #364 (comment)

Copy link
Collaborator

@simon04 simon04 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@simon04 simon04 merged commit e11217b into perliedman:master Aug 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants