Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perl_mongers.json diffs are huge every flush #117

Closed
jhannah opened this issue Jul 6, 2017 · 4 comments
Closed

perl_mongers.json diffs are huge every flush #117

jhannah opened this issue Jul 6, 2017 · 4 comments

Comments

@jhannah
Copy link
Member

jhannah commented Jul 6, 2017

@ranguard hey we abandoned WebDAV for git push publishing. Interestingly the JSON file

https://github.com/perlorg/www.pm.org/blob/master/bin/xml#L346

Is now by far the largest diff when a group changes, since it's order is random?

 OLD-STUFF/admins/metabase/metadata/ToDo |    4 +-
 faq/admin.html                          |    2 +-
 faq/hosting_faq.html                    |    2 +-
 faq/index.html                          |    2 +-
 groups/index.html                       |    6 +-
 groups/map.html                         |    2 +-
 groups/north_america.html               |    3 +-
 groups/perl_mongers.json                | 9484 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++------------------------------------------------------------------------------
 groups/perl_mongers.xml                 |    2 +-
 groups/united_states_of_america.html    |   12 +-
 index.html                              |    4 +-
 start/index.html                        |    2 +-
 successful/index.html                   |    2 +-
 13 files changed, 4749 insertions(+), 4778 deletions(-)

In case you had any thoughts about ordering it or something to make the diffs sane? :)

@ranguard
Copy link
Member

ranguard commented Jul 6, 2017

Does that help?

@ranguard ranguard closed this as completed Jul 6, 2017
@jhannah
Copy link
Member Author

jhannah commented Jul 6, 2017

It doesn't seem to. I flushed it, committed locally, changed 1 group, flushed it again:

 groups/perl_mongers.json             | 8060 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++-------------------------------------------------------------------------------

@jhannah jhannah reopened this Jul 6, 2017
@jhannah
Copy link
Member Author

jhannah commented Jul 6, 2017

Looks like the groups are sorted now, but all the keys are random, so the diff is still huge

 [
    {
-      "meetup" : "",
-      "mailing_list" : {
-         "name" : ""
-      },
-      "name" : "ABE.pm",
+      "state" : "Pennsylvania",
+      "location" : "Allentown-Bethlehem-Easton, Pennsylvania, Lehigh Valley / ABE, United States of America, North America",
+      "facebook" : "",
+      "longitude" : "-75.370833",
       "tsar" : [
          {
-            "mail" : "rjbs <replace me by @> cpan.org",
-            "name" : "Ricardo Signes"
+            "name" : "Ricardo Signes",
+            "mail" : "rjbs <replace me by @> cpan.org"
          }
       ],
-      "description" : "Perl Mongers Allentown-Bethlehem-Easton, Pennsylvania, Lehigh Valley / ABE, United States of America, North America is the Perl users group that organizes meetings",
-      "location" : "Allentown-Bethlehem-Easton, Pennsylvania, Lehigh Valley / ABE, United States of America, North America",
-      "zoom" : 11,
-      "state" : "Pennsylvania",
-      "linked_location" : "Allentown-Bethlehem-Easton, Pennsylvania, Lehigh Valley / ABE, <a href=\"united_states_of_america.html\">United States of America</a>, <a href=\"north_america.html\">North Amer
ica</a>",
+      "continent" : "North America",
+      "linkedin" : "",
       "id" : "626",
-      "latitude" : "40.625833",
-      "googleplus" : "",
       "status" : "active",
+      "linked_location" : "Allentown-Bethlehem-Easton, Pennsylvania, Lehigh Valley / ABE, <a href=\"united_states_of_america.html\">United States of America</a>, <a href=\"north_america.html\">North Amer
ica</a>",

@jacoby
Copy link
Contributor

jacoby commented Jul 7, 2017

Found out something new about JSON. Will PR a fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants