Rename OPAL_SERVER_PORT to OPAL_SERVER_BIND_PORT #442
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for opal-docs ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
`OPAL_SERVER_PORT` was often set by k8s to the string "tcp://..." when a service named "opal-server" existed in the current namespace. Rename it to `OPAL_SERVER_BIND_PORT`. To maintain backward compatibility - still use `OPAL_SERVER_PORT` if it is has a valid value
roekatz
force-pushed
the
rk/fix-server-url-envar
branch
from
02c4ad4
to
c07bb7f
Compare
omer9564
approved these changes
Apr 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OPAL_SERVER_PORTwas often set by k8s to the string "tcp://..." when a service named "opal-server" existed in the current namespace. Rename it toOPAL_SERVER_BIND_PORT.To maintain backward compatibility - still use
OPAL_SERVER_PORTif it is has a valid value