Headers refactoring #25
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| end | ||
|
|
||
| class Request < BaseRequest | ||
| include Upload |
There was a problem hiding this comment.
I would love to use prepend from Ruby 2.0 instead ...
| def rackify(env = {}) | ||
| inject(env) do |rack, (header, value)| | ||
| key = "HTTP_" + header.upcase.gsub("-", "_") | ||
| env[key] = value |
There was a problem hiding this comment.
You need to end an inject with the object you want to pass into the next invocation. In this case, it'd be +rack+. However, you're not using the result of the inject, so use an each instead.
|
Merged #26, thanks guys. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Normalize accessing them with downcased string. Expose mongrel2 headers as request methods. Remove such headers from the list.