Skip to content
This repository has been archived by the owner on Sep 6, 2023. It is now read-only.

Fixes build issues with latest dependencies. #18

Merged
merged 1 commit into from
Apr 14, 2023

Conversation

cwoolum
Copy link
Contributor

@cwoolum cwoolum commented Apr 6, 2023

Upon upgrading to the latest version of this package, I ran into a couple of issues compiling. In mod.rs, there was a specific field that needed to be flagged for > ESP-IDF 5.0 for the esp32-c3.

I was a bit unsure how the other error was actually introduced. I wasn't able to discover why this mattered only in the recent version of esp-idf-sys.

error[E0624]: method `set_raw` is private
  --> bluedroid\src\gatt_server\custom_attributes.rs:99:22
   |
99 |                     .set_raw(&key, &value)
   |                      ^^^^^^^ private method
  --> C:\Users\developer\.cargo\registry\src\index.crates.io-6f17d22bba15001f\esp-idf-svc-0.45.0\src\nvs.rs:329:5  
   |
   = note: private method defined here
   |
   = help: items from traits can only be used if the trait is in scope
help: the following trait is implemented but not in scope; perhaps add a `use` for it:
   |
1  | use embedded_svc::storage::RawStorage;
   |

For more information about this error, try `rustc --explain E0624`.
error: could not compile `bluedroid` (lib) due to previous error

@cwoolum
Copy link
Contributor Author

cwoolum commented Apr 6, 2023

Fixed the formatting issue and pushed again. Build should succeed this time.

@cwoolum cwoolum force-pushed the develop branch 6 times, most recently from 6c4afa7 to db5f941 Compare April 14, 2023 05:08
@cwoolum
Copy link
Contributor Author

cwoolum commented Apr 14, 2023

This code is now ready to be merged. I have it running successfully in my own fork.

@persello persello merged commit 62d84c6 into persello:develop Apr 14, 2023
@persello persello linked an issue Apr 14, 2023 that may be closed by this pull request
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Recent support for ESP-IDF 5.0 broke 4.4
2 participants