-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CHORE] adding datasources provisioning #8
[CHORE] adding datasources provisioning #8
Conversation
Signed-off-by: Nicolas Takashi <nicolas.tcs@hotmail.com>
92ec8fc
to
a1be1b2
Compare
I don't get how Perses will consider the globalDatasource provisioned, since it should go in a specific folder in the database folder |
Actually i'm mounting the configmap under the I just tested it locally and it worked as expected. |
well the issue is that you are also mounting a volume there where the BE can write. Is it still possible to create another globalDatasource ? |
Oh now I got it! Is there anyway to test it today, since we don't have GlobalDataSource CRUD? @Nexucis |
Weeelll you have it through the CLI. It's not super easy but it should work :). |
You're so right 🥲 But I'll let another question. |
I think a good way to do it would be through CRDs then. |
I see your point and I can agree on a certain level, but I see the CRD being part of the Perses operator (under development yet), and the operator will be another option to deploy and manage Perses. With that in mind, I see this helm chart as an option to deploy and manage Perses without having to manage an operator and all its resources such as CRDs. After a while of thinking about this, my idea to overcome the read-only file system issue you pointed out is to leverage the Perses CLI as a side-car and leverage the apply command to apply the dashboards without mounting them. volume. WDT? @Nexucis |
yeah me too.
That could work indeed ! |
668c6d2
to
587cd89
Compare
587cd89
to
e5b9c7e
Compare
e5b9c7e
to
5ac46a0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🥳
Description
I'm adding the ability to provision datasources when install Perses using helm chart.
Checklist
[<catalog_entry>] <commit message>
naming convention using one of the followingcatalog_entry
values:FEATURE
,ENHANCEMENT
,BUGFIX
,BREAKINGCHANGE
,IGNORE
.