Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Move Migrate Button into "Add Dashboard" #1726

Merged
merged 1 commit into from
Jan 29, 2024

Conversation

sinkingpoint
Copy link
Contributor

Description

This introduces a "Button Menu", a CRUD Button that has a drop down next to it for more options, not unlike Githubs Merge button etc. We then use that component to move the Migrate button from the header into an option below the Add Dashboard button on the home page.

This tidies up the UI a bit, but also sets the stage for a more generic "Import Dashboard" button that can be used to import dashboards from other sources.

Screenshots

image

Checklist

  • Pull request has a descriptive title and context useful to a reviewer.
  • Pull request title follows the [<catalog_entry>] <commit message> naming convention using one of the
    following catalog_entry values: FEATURE, ENHANCEMENT, BUGFIX, BREAKINGCHANGE, DOC,IGNORE.
  • All commits have DCO signoffs.

UI Changes

  • Changes that impact the UI include screenshots and/or screencasts of the relevant changes.
  • Code follows the UI guidelines.
  • Visual tests are stable and unlikely to be flaky.
    See Storybook
    and e2e docs for more details. Common issues
    include:
    • Is the data inconsistent? You need to mock API requests.
    • Does the time change? You need to use consistent time values or mock time utilities.
    • Does it have loading states? You need to wait for loading to complete.

Copy link
Member

@celian-garcia celian-garcia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's a good start!

Maybe we can have something a bit more extandable like this review changes view.

Something that when you click, it is opening a dropdown bigger allowing you to, directly from the dropdown, either

  • Start a new -> Go to the new page
  • Import from file/textarea
  • Import from Grafana -> Grafana ID/textarea

It is a bit more work that does not fit in one PR only for sure. But shouldn't we brainstorm about that in a github discussion + figma ?

This introduces a "Button Menu", a CRUD Button that has a drop down next
to it for more options, not unlike Githubs Merge button etc. We then
use that component to move the Migrate button from the header
into an option below the Add Dashboard button on the home page.

This tidies up the UI a bit, but also sets the stage for a more generic
"Import Dashboard" button that can be used to import dashboards from
other sources.

Signed-off-by: sinkingpoint <colin@quirl.co.nz>
@sinkingpoint
Copy link
Contributor Author

I'm working off of
https://www.figma.com/file/D9VznEcxMYrhyVwSb6fLuf/Perses-Design?type=design&node-id=708-10820&mode=design&t=2kaT4H74NmBauGny-0

which got shared a couple of meetings ago iirc

Copy link
Member

@Gladorme Gladorme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@Gladorme Gladorme added this pull request to the merge queue Jan 29, 2024
Merged via the queue into perses:main with commit a315d8c Jan 29, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants