Fixed the third month of jalali calendar. (Issue #15) #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fzerorubigd
reviewed
Oct 1, 2019
There was a problem hiding this comment.
There is a conversation about the keys #27 we need to decide on that before any change
|
LGTM, waiting for #27 |
fzerorubigd
requested changes
Oct 1, 2019
hramezani
force-pushed
the
edit_khordad
branch
from
44fc52a
to
20dc4a7
Compare
|
@hramezani you need to remove the |
hramezani
force-pushed
the
edit_khordad
branch
from
20dc4a7
to
6e5098b
Compare
|
خیلی جالبه که تست درست کار نکرد :)) توی لاگ خطا داده ولی متاسفانه گرین مونده :) لطفا |
|
البته اگه گو نسخه آخر نداری و مشکل داری میتونم من یه کامیت اضافه کنم . نسخه ۱.۱۳ میخواد. |
|
من نسخه آخر رو نصب میکنم و سینک میکنم. دوباره آپدیت میکنم |
|
@fzerorubigd, Done. |
fzerorubigd
approved these changes
Oct 2, 2019
|
Great! thank you. |
neda1985
pushed a commit
to neda1985/cal-events
that referenced
this pull request
Oct 6, 2019
Fixed the third month of jalali calendar. (Issue persiancal#15)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.