Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revive planSnap() not to break downstream #414

Merged
merged 4 commits into from
May 12, 2018
Merged

Conversation

jslee02
Copy link
Member

@jslee02 jslee02 commented May 11, 2018

We will keep old function planSnap() for the downstream projects until they settled to the new planning API.


Before creating a pull request

  • Document new methods and classes
  • Format code with make format

Before merging a pull request

  • Set version target by selecting a milestone on the right side
  • Summarize this change in CHANGELOG.md

@jslee02 jslee02 added this to the Aikido 0.3.0 milestone May 11, 2018
brianhou
brianhou previously approved these changes May 11, 2018
@codecov
Copy link

codecov bot commented May 12, 2018

Codecov Report

Merging #414 into master will decrease coverage by 0.1%.
The diff coverage is 0%.

@@            Coverage Diff             @@
##           master     #414      +/-   ##
==========================================
- Coverage   79.57%   79.46%   -0.11%     
==========================================
  Files         230      231       +1     
  Lines        5944     5952       +8     
==========================================
  Hits         4730     4730              
- Misses       1214     1222       +8
Impacted Files Coverage Δ
src/planner/SnapPlanner.cpp 0% <0%> (ø)

@jslee02 jslee02 merged commit 5d653e8 into master May 12, 2018
@jslee02 jslee02 deleted the revive_snap_planner branch May 12, 2018 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants