Bugfix/memory leak #483
Merged
Bugfix/memory leak #483
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit b93b264.
brianhou
previously approved these changes
Jan 16, 2019
Co-Authored-By: gilwoolee <gilwoo301@gmail.com>
brianhou
previously approved these changes
Jan 19, 2019
jslee02
reviewed
Jan 20, 2019
…ics/aikido into bugfix/memory_leak
jslee02
previously approved these changes
Jan 20, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes memory leak in
Interpolated::addWaypoint, which usesallocateStatebut never frees. This PR adds destructor and callsfreeStateduring destruction.I tested with valgrind in test_ParabolicTimer and it reduces memory leak from 803 bytes to 51 bytes (the 51 bytes are coming from something else at the moment.)
Before creating a pull request
make formatBefore merging a pull request
CHANGELOG.md