Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migration to spa #54

Merged
merged 31 commits into from
Apr 19, 2024
Merged

Migration to spa #54

merged 31 commits into from
Apr 19, 2024

Conversation

lperezp
Copy link
Collaborator

@lperezp lperezp commented Apr 5, 2024

Hola!, propongo hacer unos cambios, esto con el fin de simplificar y que esté activo el sitio con información actualizada.

Cambios propuestos:

Hacer un SPA con Angular para que el rendimiento sea mejor.

Más detalles en el issue #53

@lperezp lperezp added the enhancement New feature or request label Apr 5, 2024
@lperezp lperezp linked an issue Apr 5, 2024 that may be closed by this pull request
@joelibaceta
Copy link
Member

@lperezp Haz pensado como se haria el build automatico? 🤔 creo que deberiamos incluir cambios en el workflow de github actions para que haga el build y actualice el gh-pages con el resultado para que se actualice automaticamente con el merge de PRs a master

@lperezp
Copy link
Collaborator Author

lperezp commented Apr 5, 2024

Cierto, ahora cargo el nuevo archivo para desplegar a master

@lperezp
Copy link
Collaborator Author

lperezp commented Apr 5, 2024

@joelibaceta se actualizó el archivo YML para los pases de master.

@lperezp
Copy link
Collaborator Author

lperezp commented Apr 16, 2024

@joelibaceta con estos cambios se estaría desplegando el proyecto con la nueva interfaz. La data seguiría en un archivo para que sea actualizado mediante PRs.

Readme.md Outdated
Comment on lines 1 to 27
# PeruanosGithubIo

¡Hola!. Estamos creando un directorio con todas las comunidades de tecnología en el Perú.
This project was generated with [Angular CLI](https://github.com/angular/angular-cli) version 17.3.0.

Si no encuentras tu comunidad, puedes agregarla desde [aquí](https://github.com/peruanosdev/peruanos.github.io/edit/master/_data/communities.json).
## Development server

## Configuración Local (Modo Desarrollo)
Run `ng serve` for a dev server. Navigate to `http://localhost:4200/`. The application will automatically reload if you change any of the source files.

Para levantar la aplicación localmemte sigue los siguientes pasos:
## Code scaffolding

1. Asegúrate de tener instalado Ruby
2. Instala las dependencias: `bundle install`
3. Obtener datos: `rake prepare`
4. Empezar la app: `bundle exec jekyll serve`
5. Ir a la [app](http://127.0.0.1:4000)
Run `ng generate component component-name` to generate a new component. You can also use `ng generate directive|pipe|service|class|guard|interface|enum|module`.

## Build

Run `ng build` to build the project. The build artifacts will be stored in the `dist/` directory.

## Running unit tests

Run `ng test` to execute the unit tests via [Karma](https://karma-runner.github.io).

## Running end-to-end tests

Run `ng e2e` to execute the end-to-end tests via a platform of your choice. To use this command, you need to first add a package that implements end-to-end testing capabilities.

## Further help

To get more help on the Angular CLI use `ng help` or go check out the [Angular CLI Overview and Command Reference](https://angular.io/cli) page.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Creo que estaria bueno no perder el readme, menos reemplazarlo por uno autogenerado y generico

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hola Joel, se actualizó el readme en este commit. 3c3bf8d

@joelibaceta joelibaceta self-requested a review April 18, 2024 22:39
@joelibaceta
Copy link
Member

@lperezp aprobado 👍

@lperezp lperezp merged commit 2b760a1 into master Apr 19, 2024
1 check passed
@lperezp lperezp deleted the migration-to-spa branch April 19, 2024 00:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Migración a un SPA
2 participants