Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Existing security issues #40

Open
guardrails bot opened this issue Dec 15, 2018 · 2 comments
Open

Existing security issues #40

guardrails bot opened this issue Dec 15, 2018 · 2 comments

Comments

@guardrails
Copy link

guardrails bot commented Dec 15, 2018

⚠️ Here are the existing security issues we detected on your default branch:

Insecure Network Communication (3)

More info on how to fix Insecure Network Communication in Python.

@CosmicDuck
Copy link

Hello,

simply replacing False by True was working for me. So the fix should be easy, isn't it?

@peshay
Copy link
Owner

peshay commented Mar 17, 2022

Hi! I recently put not much time into this project. There is also a PR that show a good option: #58
I think it would really be good to replace it with an option in the Connection object in line 110:

 def __init__(self, api_key, api_secret, ssl_verify=False):

So at later lines this variable can be used.

Despite this is just a hobby and I have no contributors, I have certain expectations to a PR.
Because I set everything up with unit test, I also want for every change

  • A well written commit message
  • A unit test, so it can be verified that the change does what it's expected to do
  • If something changes how the code behaves, it should be documented in the README file (Here for example we add a new option to the Connection object)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants