A bunch of refactors #103
Merged
A bunch of refactors #103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gituser143
requested review from
MadhavJivrajani and
metonymic-smokey
as code owners
|
@MadhavJivrajani, Here to annoy you for another PR review :P |
Co-authored-by: Madhav Jivrajani <madhav.jiv@gmail.com>
MadhavJivrajani
requested changes
May 6, 2021
MadhavJivrajani
approved these changes
May 6, 2021
MadhavJivrajani
added a commit
that referenced
this pull request
May 12, 2021
* Update install instructions in README * Add binary compile script * Moved compile script to scripts directory * Add license to compile.sh * add bin/ to gitignore * Optimize struct memory usage * reorder struct fields * Updated config.yml * Updated config.yml * remove field align check from CI * add check existence of fieldalignment command * Update README.md * remove xml mention from README * Tidied go.mod * Add apt update to ci scripts * Add Container metric functionality (#102) * Add overall metrics collection * Replace net and blk slices with structs * Init UI for containers * Replace tick with NewTicker * Add help page for overallContainer * Format container UI * Modify container about * Add container table fit and resize * Removed redundant helper * Resize list content according to table widths * Auto Resize Disk chart * Replace tick with NewTicker and fix container table alignment issues * Add License * Remove empty file * Missing license fix * Add auto resize for cpu info table * Add basic UI for per container metrics * Fix per cpu value error * Add table scroll functionality for per container UI * Remove invalid test file * Fix dot imports, use of "self" and ineffective break * Cleanup container metrics and document code * Migrate overallcontainer list to table and add cursor colours * Add error art functionality for containers * Add checks for empty precpu metrics * Replace one shot container stats fetch * Handle docker not running error * Add docker alias for `grofer container` * Add host ip in port map list * Add getCPUPercent functions and tests for funcs * Add missing license * Replace cpu percent calculation with new func in overall.go * Add test for RoundValues with inBytes * Add details for exported container metrics structs * Minor comments added to explain TickUntilDone * Fix incorrect timestamps (#105) * Fix incorrect timestamps * Update tests * A bunch of refactors (#103) * Add table to grofer proc * Re Add proc kill functionality * Add table for per proc child procs * Add % symbol to cpuinfo * Add cleaner network graph and remove nettext chart * Tidy go mod * Add missing license and ctx.Done() to UI * Update README * Add CPU table for overall when numCores > 8 * Add CPU table for --cpuinfo when numCores > 8 * Add extra tests to CI * Removed unused NetTable widget * Sort procs on Timestamp * Update src/utils/lineGraph.go Co-authored-by: Madhav Jivrajani <madhav.jiv@gmail.com> * Readme and CI config update * Add credit and cocument exported function * Remove -race from CI tests * Remove default sort Co-authored-by: Madhav Jivrajani <madhav.jiv@gmail.com> * Add Sort functionality to overall process and container tables (#109) * Add sort functionality to all procs * Restructure switch cases * Add sort for container table * Update keybindings for sort * Explain kill confirmation in keybindings * Restructure sorts * Minor comment changes to sort.go * Add tests for sortData * Add missing license to test file * Add Container Actions! (#110) * Add container pause action * Add global cli, cliMutex and container restart action * Remove cliMutex, add check for mem 0/0 error and container stop functionality * Add `--all` flag for `grofer container` * Add container kill and remove actions * add error screen for container * Add containerWait * Add cursor selectin colour after error * Update help keybindings * Add leybindings, recover() to utils wrapper and close chans * Add --all flag for refresh after container action * use ct.Done as stop chan * Add comment for ContainerWait() * Add stats.Body.Close() and removed close of chan on receiver Co-authored-by: Madhav Jivrajani <madhav.jiv@gmail.com> * Add missing ctx.Done() for serve data functions Co-authored-by: Madhav Jivrajani <madhav.jiv@gmail.com> Co-authored-by: Sparsh Temani <sparshtemani31415@gmail.com>
Gituser143
added a commit
that referenced
this pull request
Sep 10, 2021
* Update to version v1.3.0! (#111) * Update install instructions in README * Add binary compile script * Moved compile script to scripts directory * Add license to compile.sh * add bin/ to gitignore * Optimize struct memory usage * reorder struct fields * Updated config.yml * Updated config.yml * remove field align check from CI * add check existence of fieldalignment command * Update README.md * remove xml mention from README * Tidied go.mod * Add apt update to ci scripts * Add Container metric functionality (#102) * Add overall metrics collection * Replace net and blk slices with structs * Init UI for containers * Replace tick with NewTicker * Add help page for overallContainer * Format container UI * Modify container about * Add container table fit and resize * Removed redundant helper * Resize list content according to table widths * Auto Resize Disk chart * Replace tick with NewTicker and fix container table alignment issues * Add License * Remove empty file * Missing license fix * Add auto resize for cpu info table * Add basic UI for per container metrics * Fix per cpu value error * Add table scroll functionality for per container UI * Remove invalid test file * Fix dot imports, use of "self" and ineffective break * Cleanup container metrics and document code * Migrate overallcontainer list to table and add cursor colours * Add error art functionality for containers * Add checks for empty precpu metrics * Replace one shot container stats fetch * Handle docker not running error * Add docker alias for `grofer container` * Add host ip in port map list * Add getCPUPercent functions and tests for funcs * Add missing license * Replace cpu percent calculation with new func in overall.go * Add test for RoundValues with inBytes * Add details for exported container metrics structs * Minor comments added to explain TickUntilDone * Fix incorrect timestamps (#105) * Fix incorrect timestamps * Update tests * A bunch of refactors (#103) * Add table to grofer proc * Re Add proc kill functionality * Add table for per proc child procs * Add % symbol to cpuinfo * Add cleaner network graph and remove nettext chart * Tidy go mod * Add missing license and ctx.Done() to UI * Update README * Add CPU table for overall when numCores > 8 * Add CPU table for --cpuinfo when numCores > 8 * Add extra tests to CI * Removed unused NetTable widget * Sort procs on Timestamp * Update src/utils/lineGraph.go Co-authored-by: Madhav Jivrajani <madhav.jiv@gmail.com> * Readme and CI config update * Add credit and cocument exported function * Remove -race from CI tests * Remove default sort Co-authored-by: Madhav Jivrajani <madhav.jiv@gmail.com> * Add Sort functionality to overall process and container tables (#109) * Add sort functionality to all procs * Restructure switch cases * Add sort for container table * Update keybindings for sort * Explain kill confirmation in keybindings * Restructure sorts * Minor comment changes to sort.go * Add tests for sortData * Add missing license to test file * Add Container Actions! (#110) * Add container pause action * Add global cli, cliMutex and container restart action * Remove cliMutex, add check for mem 0/0 error and container stop functionality * Add `--all` flag for `grofer container` * Add container kill and remove actions * add error screen for container * Add containerWait * Add cursor selectin colour after error * Update help keybindings * Add leybindings, recover() to utils wrapper and close chans * Add --all flag for refresh after container action * use ct.Done as stop chan * Add comment for ContainerWait() * Add stats.Body.Close() and removed close of chan on receiver Co-authored-by: Madhav Jivrajani <madhav.jiv@gmail.com> * Add missing ctx.Done() for serve data functions Co-authored-by: Madhav Jivrajani <madhav.jiv@gmail.com> Co-authored-by: Sparsh Temani <sparshtemani31415@gmail.com> * Merge changes from main, upgrade to v1.4.0 Co-authored-by: Madhav Jivrajani <madhav.jiv@gmail.com> Co-authored-by: Sparsh Temani <sparshtemani31415@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Made a bunch of refactors.
Type of change
Please delete options that are not relevant.
Checklist:
go fmton my code (reference)