Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi!
I started using
pest-ast
and I was running into the following lint:Personally I think it is desirable to have it on, so I checked out
pest-ast
's code and noticed that the first element in theConversionStrategy::Outer
tuple is always aSpan
, which isCopy
and thus shouldn't ever needclone
.I have not delved super deep in the code, though, so I'm not 100% confident on this statement: have I overlooked something?
I also changed the example slightly, removing the need for allowing lints altogether. Hth!