Set-ItResult: Return distinctive ErrorId depending on switch used

[csandfeld]

PR Summary

• Set-ItResult updated to return distinctive ErrorId depending on switch used (previously always returned PesterTestSkipped).
  • -Inconclusive now returns PesterTestInconclusive
  • -Pending now returns PesterTestPending
  • Skipped still returns PesterTestSkipped
• Invoke-TestItem in Pester.Runtime updated to handle additional ErrorId´s.
• Existing Set-ItResult Pester tests re-enabled.

I am not sure if these changes require additional tests and/or documentation updates - let me know if they do.

Related to issue #2400.

PR Checklist

• PR has meaningful title
• Summary describes changes
• PR is ready to be merged
  • If not, use the arrow next to Create Pull Request to mark it as a draft. PR can be marked Ready for review when it's ready.
• Tests are added/update (if required)
• Documentation is updated/added (if required)

[nohwnd]

@fflaten what you commented on in the Issue happens here. The error record id is translated to .Skipped = $true on the test object. So all the accounting that is done above this is correct, but you can still see the actual reason for marking the test as skipped on the ErrorRecord itself on the Result object.

[fflaten]

Thanks 🙂 Didn't remember that Add-RSpecTestObjectProperties would set the correct result based on Skipped = $true during teardown.

[fflaten]

LGTM as a first step. 🙂

I'd prefer to change the output a little, but unfortunately it could be a minor breaking change since it was the only identifier for inconclusive/pending until now. E.g.

  # From
  [!] Test123 is skipped, because INCONCLUSIVE: test 245.6s (143.4s|102.2s)
  [!] Test456 is skipped, because PENDING: test 5ms (2ms|3ms)
  
  # To (until one or both Are proper result values again)
  [!] Test123 is skipped (inconclusive), because test 245.6s (143.4s|102.2s)
  [!] Test456 is skipped (pending), because test 5ms (2ms|3ms)

[nohwnd]

@fflaten yeah let's not change the output, so we don't break the existing workarounds, while there is no complete solution in place.

[nohwnd]

Merged, thanks guys :)

[csandfeld]

Merged, thanks guys :)

My pleasure :)