-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Get-Help links (in the Pester source files) #8
Comments
I can pick this one up. |
Cool, that would be awesome. Please keep a couple of things in mind.
Does that sound ok to you? |
Yes, think so. |
Broke the blocks of links into separate chunks yesterday but before I go any further, I want to check about the actual link text. I get that some are using the old url and the wrong page name that can be fixed. I am more wondering about whether each command should have an online link to the docs . For example I think this is correct (with comments afterwards): Context ... .LINK .LINK .LINK |
I guess @nohwnd should check your Pester PR, see what he thinks. |
If you are for example suggesting we should leave ‘about_Should’ exactly that text then I wonder what happens inside Docusaurus. Does it produce a valid URL by itself? If not, changing it to full url should be the best solution IMO but that’s personal. I prefer to see full links when running Get-Help but... perhaps other systems/tools expect this format. Apologies for the long text, was a bit of a long day |
No, no problem. I'll make a PR as it is with fixed links etc. but leave the rest alone for now and we can see what opinions come out. |
Aha, I think I understand now. I will generate a PR here using your Pester PR somewhere this Friday or weekend. That way we can reason about/view the outcome. Thanks again! |
From pester/docs#8 Changed all links from pester/wiki to new pester.dev. Added some extra .LINK entries to online docs where missing on some commands.
Added a note about what the correct format is for all .LINK entries. |
* Fix Get-Help links From pester/docs#8 Changed all links from pester/wiki to new pester.dev. Added some extra .LINK entries to online docs where missing on some commands. * Full urls in link blocks Changed all .LINK sections to be full urls. Removed self-referencing links or replaced with complenting command. Eg. BeforeEach and AfterEach
The auto-generated Command Reference pages use the Get-Help information produced by Pester. PlatyPS is used to make the first conversion to markdown, Alt3.Docusaurus.Powershell then enriches the markdown so it becomes compatible with Docusaurus.
The Pester sources may contain Get-Help
.LINK
sections which are converted toExternal Links
as shown below:As you can see there are currently two issues, to be fixed in the Pester source file:
Another issue that might occur in the source files is this example taken from https://github.com/pester/Pester/blob/master/Functions/Mock.ps1:
which leads to this funky link in the browser:
Should be fixed by creating separate
.LINK
entities as per the specification. E.g.The text was updated successfully, but these errors were encountered: