Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace wiki-links with valid markdown links #24

Merged
merged 3 commits into from
Jan 21, 2020

Conversation

deejaygraham
Copy link
Contributor

Replaced formatting of [[foo]] links with foo format. Fixed some broken links in the quick-start page.

Fix markdown links for It, Describe, Invoke-Pester
Use new markdown format for links in usage folder. Add missed link in quick start.
@deejaygraham
Copy link
Contributor Author

Hmm, had it working locally but netlify is showing I've messed something up with a couple of links. Will look again.

@bravo-kernel
Copy link
Collaborator

No worries, you will get it right, it's highly appreciated ❤️

@bravo-kernel
Copy link
Collaborator

ps: do not worry about the left sidebar disappearing when opening links in new tabs while testing, it's an issue related to D2/Netlify and is currently being looked at

@deejaygraham
Copy link
Contributor Author

That looks better now :)

@bravo-kernel
Copy link
Collaborator

bravo-kernel commented Jan 20, 2020

It's awesome, I just checked all links and they all worked perfectly. Please let us know if you think it is ready to merge as well and I will merge this straight in

@deejaygraham
Copy link
Contributor Author

Yep I think it's ready to go, I think I got them all. Thanks for the help.

@bravo-kernel bravo-kernel merged commit f16feac into pester:master Jan 21, 2020
@bravo-kernel
Copy link
Collaborator

Thanks mr. @deejaygraham, this was the PR with the most visible impact on the website visitors so highly appreciated 👏

@deejaygraham deejaygraham deleted the markdown-links branch January 23, 2020 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants