Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add usage docs #70

Merged
merged 14 commits into from
Nov 20, 2020
Merged

Add usage docs #70

merged 14 commits into from
Nov 20, 2020

Conversation

nohwnd
Copy link
Member

@nohwnd nohwnd commented Nov 8, 2020

No description provided.

@nohwnd
Copy link
Member Author

nohwnd commented Nov 8, 2020

@fflaten help me review it pls.

Click the live preview.
image
(not sure if you worked with this already)

Copy link
Collaborator

@fflaten fflaten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks very good! I've added a couple of suggestions

docs/usage/discovery-and-run.mdx Outdated Show resolved Hide resolved
docs/usage/discovery-and-run.mdx Outdated Show resolved Hide resolved
docs/usage/discovery-and-run.mdx Outdated Show resolved Hide resolved
docs/usage/discovery-and-run.mdx Outdated Show resolved Hide resolved
docs/usage/discovery-and-run.mdx Outdated Show resolved Hide resolved
docs/usage/importing-tested-functions.mdx Outdated Show resolved Hide resolved
docs/usage/test-file-structure.mdx Outdated Show resolved Hide resolved
docs/usage/test-file-structure.mdx Outdated Show resolved Hide resolved
docs/usage/test-file-structure.mdx Outdated Show resolved Hide resolved
docs/usage/test-file-structure.mdx Outdated Show resolved Hide resolved
@nohwnd nohwnd mentioned this pull request Nov 9, 2020
Co-authored-by: Frode Flaten <3436158+fflaten@users.noreply.github.com>
@fflaten
Copy link
Collaborator

fflaten commented Nov 14, 2020

Remove this section in this PR? PSGet-link is dead and PowerShell 2.0 support was dropped in Pester v5.

@fflaten
Copy link
Collaborator

fflaten commented Nov 15, 2020

Great job on the data-driven tests page!

docs/usage/discovery-and-run.mdx Show resolved Hide resolved
docs/usage/discovery-and-run.mdx Outdated Show resolved Hide resolved
docs/usage/importing-tested-functions.mdx Show resolved Hide resolved
docs/usage/test-cases.mdx Outdated Show resolved Hide resolved
docs/usage/setup-and-teardown.mdx Outdated Show resolved Hide resolved
docs/usage/test-file-structure.mdx Outdated Show resolved Hide resolved
@nohwnd
Copy link
Member Author

nohwnd commented Nov 15, 2020

Added bunch more. Will address the review comments later.

@nohwnd
Copy link
Member Author

nohwnd commented Nov 15, 2020

Remove this section in this PR? PSGet-link is dead and PowerShell 2.0 support was dropped in Pester v5.

done.

nohwnd and others added 2 commits November 15, 2020 18:52
Co-authored-by: Frode Flaten <3436158+fflaten@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants