-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor oinq
into Two Separate Crates: oinq
for Network Communication and review-protocol
for Application Protocol
#60
Labels
refactor
Code refactoring
Comments
msk
changed the title
Refactor
Refactor Mar 18, 2024
oinq
into Two Separate Crates: oinq
for Network Communication and review-client
for Application Protocoloinq
into Two Separate Crates: oinq
for Network Communication and review-protocol
for Application Protocol
msk
added a commit
to aicers/crusher
that referenced
this issue
Mar 22, 2024
This commit refactors the dependencies to replace direct dependencies on oinq with dependencies on review-protocol. This refactor addresses the issue raised in petabi/oinq#60, and does not introduce any functional change to the application.
kimhanbeom
pushed a commit
to aicers/crusher
that referenced
this issue
Mar 28, 2024
This commit refactors the dependencies to replace direct dependencies on oinq with dependencies on review-protocol. This refactor addresses the issue raised in petabi/oinq#60, and does not introduce any functional change to the application.
msk
added a commit
to aicers/review-web
that referenced
this issue
Mar 29, 2024
This commit refactors the dependencies to replace direct dependencies on oinq with dependencies on review-protocol. This refactor addresses the issue raised in petabi/oinq#60, and does not introduce any functional change to the application.
sehkone
pushed a commit
to aicers/review-web
that referenced
this issue
Apr 1, 2024
This commit refactors the dependencies to replace direct dependencies on oinq with dependencies on review-protocol. This refactor addresses the issue raised in petabi/oinq#60, and does not introduce any functional change to the application.
This was referenced Apr 1, 2024
Merged
Resolved in oinq-0.12.0 and review-protocol-0.2.0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
oinq
has been instrumental in implementing the communication protocol between agents in the REview ecosystem, leveraging the QUIC protocol for efficient and secure communication. However, we've identified an opportunity to enhance modularity and code reuse within the broader ecosystem, specifically with projects likegiganto-client
that also rely on QUIC for network communication.To promote code reuse and foster collaboration among projects utilizing QUIC, I propose we refactor
oinq
into two separate crates:oinq
: This crate will focus solely on low-level network communication, such as sending and receiving messages and streams.review-protocol
: Built on top ofoinq
, this crate will implement the application-specific protocol for the REview ecosystem.The text was updated successfully, but these errors were encountered: