Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor oinq into Two Separate Crates: oinq for Network Communication and review-protocol for Application Protocol #60

Closed
msk opened this issue Feb 22, 2024 · 1 comment
Assignees
Labels
refactor Code refactoring

Comments

@msk
Copy link
Contributor

msk commented Feb 22, 2024

oinq has been instrumental in implementing the communication protocol between agents in the REview ecosystem, leveraging the QUIC protocol for efficient and secure communication. However, we've identified an opportunity to enhance modularity and code reuse within the broader ecosystem, specifically with projects like giganto-client that also rely on QUIC for network communication.

To promote code reuse and foster collaboration among projects utilizing QUIC, I propose we refactor oinq into two separate crates:

  1. oinq: This crate will focus solely on low-level network communication, such as sending and receiving messages and streams.
  2. review-protocol: Built on top of oinq, this crate will implement the application-specific protocol for the REview ecosystem.
@msk msk added the refactor Code refactoring label Feb 22, 2024
@msk msk changed the title Refactor oinq into Two Separate Crates: oinq for Network Communication and review-client for Application Protocol Refactor oinq into Two Separate Crates: oinq for Network Communication and review-protocol for Application Protocol Mar 18, 2024
msk added a commit to aicers/crusher that referenced this issue Mar 22, 2024
This commit refactors the dependencies to replace direct dependencies
on oinq with dependencies on review-protocol. This refactor addresses
the issue raised in petabi/oinq#60, and does not introduce any
functional change to the application.
kimhanbeom pushed a commit to aicers/crusher that referenced this issue Mar 28, 2024
This commit refactors the dependencies to replace direct dependencies
on oinq with dependencies on review-protocol. This refactor addresses
the issue raised in petabi/oinq#60, and does not introduce any
functional change to the application.
msk added a commit to aicers/review-web that referenced this issue Mar 29, 2024
This commit refactors the dependencies to replace direct dependencies
on oinq with dependencies on review-protocol. This refactor addresses
the issue raised in petabi/oinq#60, and does not introduce any
functional change to the application.
sehkone pushed a commit to aicers/review-web that referenced this issue Apr 1, 2024
This commit refactors the dependencies to replace direct dependencies
on oinq with dependencies on review-protocol. This refactor addresses
the issue raised in petabi/oinq#60, and does not introduce any
functional change to the application.
@msk msk self-assigned this Apr 4, 2024
@msk
Copy link
Contributor Author

msk commented Apr 4, 2024

Resolved in oinq-0.12.0 and review-protocol-0.2.0.

@msk msk closed this as completed Apr 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor Code refactoring
Projects
None yet
Development

No branches or pull requests

1 participant