Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add default resolver to Lighthouse docker images. #120

Merged
merged 2 commits into from Mar 3, 2020
Merged

Add default resolver to Lighthouse docker images. #120

merged 2 commits into from Mar 3, 2020

Conversation

ghost
Copy link

@ghost ghost commented Jan 11, 2020

Using the recently added environment variable configuration via akkadotnet-bootstrap, I've added the default configuration as follows:

akka.cluster.split-brain-resolver.active-strategy=keep-majority

Closes #115

@ghost ghost requested a review from Aaronontheweb as a code owner January 11, 2020 04:41
@claassistantio
Copy link

claassistantio commented Jan 11, 2020

CLA assistant check
All committers have signed the CLA.

Copy link
Author

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was done because ENV values are not transferrable between intermediate containers. And, we need the config visible to the final runtime image
.

Copy link
Member

@Aaronontheweb Aaronontheweb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kodiakhq kodiakhq bot merged commit 65132c6 into petabridge:dev Mar 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature: add ability to specify Akka.Cluster SplitBrainResolver strategy via environment variable
2 participants