Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix API key redacting for DEBUG=2 #140

Merged
merged 4 commits into from
Dec 20, 2014
Merged

Fix API key redacting for DEBUG=2 #140

merged 4 commits into from
Dec 20, 2014

Conversation

petems
Copy link
Owner

@petems petems commented Dec 3, 2014

Just noticed it doesnt work properly, fixed and added a spec to catch these sort of issues next time

Peter Souter added 4 commits December 3, 2014 16:44
* Fits in with how we already check stdout in specs
* Easier to mock without errors about re-declaring a constant
Before logic was dependant on environment variables being strings, this is much better 👍
petems added a commit that referenced this pull request Dec 20, 2014
Fix API key redacting for DEBUG=2
@petems petems merged commit 65dfe90 into master Dec 20, 2014
@petems petems deleted the fix_debug_logging branch December 20, 2014 22:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant