New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(WIP) Use rspec to_output #269

Closed

petems wants to merge 1 commit into master from refactor_to_use_to_stdout_matcher

Owner

petems commented Jun 27, 2017

No description provided.

coveralls commented Jun 27, 2017 •

edited

Loading

Coverage decreased (-2.1%) to 95.861% when pulling 1d40962 on refactor_to_use_to_stdout_matcher into d7459a1 on master.

petems force-pushed the refactor_to_use_to_stdout_matcher branch from 1d40962 to e2b97b6 Compare

November 18, 2017 14:15

coveralls commented Nov 18, 2017 •

edited

Loading

Coverage decreased (-2.1%) to 95.899% when pulling e2b97b6 on refactor_to_use_to_stdout_matcher into b00493d on master.

1 similar comment

coveralls commented Nov 18, 2017

Coverage decreased (-2.1%) to 95.899% when pulling e2b97b6 on refactor_to_use_to_stdout_matcher into b00493d on master.

petems force-pushed the refactor_to_use_to_stdout_matcher branch from e2b97b6 to b82db96 Compare

November 18, 2017 14:22

coveralls commented Nov 18, 2017 •

edited

Loading

Coverage decreased (-2.08%) to 95.944% when pulling b82db96 on refactor_to_use_to_stdout_matcher into b00493d on master.

petems force-pushed the refactor_to_use_to_stdout_matcher branch from b82db96 to 5bdea87 Compare

November 18, 2017 14:27

coveralls commented Nov 18, 2017

Coverage decreased (-2.08%) to 95.944% when pulling 5bdea87 on refactor_to_use_to_stdout_matcher into b00493d on master.

3 similar comments

coveralls commented Nov 18, 2017

Coverage decreased (-2.08%) to 95.944% when pulling 5bdea87 on refactor_to_use_to_stdout_matcher into b00493d on master.

coveralls commented Nov 18, 2017

Coverage decreased (-2.08%) to 95.944% when pulling 5bdea87 on refactor_to_use_to_stdout_matcher into b00493d on master.

coveralls commented Nov 18, 2017

Coverage decreased (-2.08%) to 95.944% when pulling 5bdea87 on refactor_to_use_to_stdout_matcher into b00493d on master.

petems force-pushed the refactor_to_use_to_stdout_matcher branch from 5bdea87 to 3585d7c Compare

November 18, 2017 14:37

coveralls commented Nov 18, 2017 •

edited

Loading

Coverage decreased (-1.9%) to 96.111% when pulling 3585d7c on refactor_to_use_to_stdout_matcher into b00493d on master.

petems force-pushed the refactor_to_use_to_stdout_matcher branch from 3585d7c to 1c4e3a5 Compare

November 18, 2017 14:40

coveralls commented Nov 18, 2017 •

edited

Loading

Coverage decreased (-1.9%) to 96.11% when pulling 1c4e3a5 on refactor_to_use_to_stdout_matcher into b00493d on master.

petems force-pushed the refactor_to_use_to_stdout_matcher branch from 1c4e3a5 to 187d393 Compare

November 18, 2017 14:44

coveralls commented Nov 18, 2017 •

edited

Loading

Coverage decreased (-1.9%) to 96.11% when pulling 187d393 on refactor_to_use_to_stdout_matcher into b00493d on master.

petems force-pushed the refactor_to_use_to_stdout_matcher branch from 187d393 to 30c70d8 Compare

November 18, 2017 15:04

coveralls commented Nov 18, 2017 •

edited

Loading

Coverage decreased (-1.9%) to 96.11% when pulling 30c70d8 on refactor_to_use_to_stdout_matcher into b00493d on master.

petems force-pushed the refactor_to_use_to_stdout_matcher branch 2 times, most recently from 4274be0 to 9c5549f Compare

November 18, 2017 15:09

coveralls commented Nov 18, 2017 •

edited

Loading

Coverage decreased (-1.8%) to 96.198% when pulling 9c5549f on refactor_to_use_to_stdout_matcher into b00493d on master.

2 similar comments

coveralls commented Nov 18, 2017

Coverage decreased (-1.8%) to 96.198% when pulling 9c5549f on refactor_to_use_to_stdout_matcher into b00493d on master.

coveralls commented Nov 18, 2017

Coverage decreased (-1.8%) to 96.198% when pulling 9c5549f on refactor_to_use_to_stdout_matcher into b00493d on master.

petems force-pushed the refactor_to_use_to_stdout_matcher branch from 9c5549f to 9924668 Compare

November 18, 2017 15:12

coveralls commented Nov 18, 2017

Coverage decreased (-1.8%) to 96.198% when pulling 9c5549f on refactor_to_use_to_stdout_matcher into b00493d on master.

3 similar comments

coveralls commented Nov 18, 2017

Coverage decreased (-1.8%) to 96.198% when pulling 9c5549f on refactor_to_use_to_stdout_matcher into b00493d on master.

coveralls commented Nov 18, 2017

Coverage decreased (-1.8%) to 96.198% when pulling 9c5549f on refactor_to_use_to_stdout_matcher into b00493d on master.

coveralls commented Nov 18, 2017

Coverage decreased (-1.8%) to 96.198% when pulling 9c5549f on refactor_to_use_to_stdout_matcher into b00493d on master.

coveralls commented Nov 18, 2017

Coverage decreased (-1.8%) to 96.198% when pulling 9924668 on refactor_to_use_to_stdout_matcher into b00493d on master.

coveralls commented Nov 18, 2017 •

edited

Loading

Coverage decreased (-1.7%) to 96.373% when pulling e91d350 on refactor_to_use_to_stdout_matcher into b00493d on master.

petems force-pushed the refactor_to_use_to_stdout_matcher branch from e91d350 to 887915c Compare

November 18, 2017 16:26

coveralls commented Nov 18, 2017 •

edited

Loading

Coverage decreased (-1.3%) to 96.683% when pulling 887915c on refactor_to_use_to_stdout_matcher into b00493d on master.

petems force-pushed the refactor_to_use_to_stdout_matcher branch from 887915c to 08a2d86 Compare

November 18, 2017 16:29

coveralls commented Nov 18, 2017

Coverage decreased (-0.2%) to 97.802% when pulling 08a2d86 on refactor_to_use_to_stdout_matcher into b00493d on master.

3 similar comments

coveralls commented Nov 18, 2017

Coverage decreased (-0.2%) to 97.802% when pulling 08a2d86 on refactor_to_use_to_stdout_matcher into b00493d on master.

coveralls commented Nov 18, 2017

Coverage decreased (-0.2%) to 97.802% when pulling 08a2d86 on refactor_to_use_to_stdout_matcher into b00493d on master.

coveralls commented Nov 18, 2017

Coverage decreased (-0.2%) to 97.802% when pulling 08a2d86 on refactor_to_use_to_stdout_matcher into b00493d on master.

petems force-pushed the refactor_to_use_to_stdout_matcher branch from 08a2d86 to 4f63a70 Compare

November 18, 2017 16:37

coveralls commented Nov 18, 2017 •

edited

Loading

Coverage decreased (-0.2%) to 97.802% when pulling 4f63a70 on refactor_to_use_to_stdout_matcher into b00493d on master.

petems force-pushed the refactor_to_use_to_stdout_matcher branch 3 times, most recently from 4dc735a to a9fe388 Compare

November 18, 2017 17:09

coveralls commented Nov 18, 2017 •

edited

Loading

Coverage decreased (-0.05%) to 97.979% when pulling 4dc735a on refactor_to_use_to_stdout_matcher into b00493d on master.

petems force-pushed the refactor_to_use_to_stdout_matcher branch from a9fe388 to ecb6f2f Compare

November 18, 2017 17:11

coveralls commented Nov 18, 2017 •

edited

Loading

Coverage decreased (-0.05%) to 97.979% when pulling a9fe388 on refactor_to_use_to_stdout_matcher into b00493d on master.

2 similar comments

coveralls commented Nov 18, 2017

Coverage decreased (-0.05%) to 97.979% when pulling a9fe388 on refactor_to_use_to_stdout_matcher into b00493d on master.

coveralls commented Nov 18, 2017

Coverage decreased (-0.05%) to 97.979% when pulling a9fe388 on refactor_to_use_to_stdout_matcher into b00493d on master.

coveralls commented Nov 18, 2017

Coverage decreased (-0.05%) to 97.979% when pulling ecb6f2f on refactor_to_use_to_stdout_matcher into b00493d on master.

3 similar comments

coveralls commented Nov 18, 2017

Coverage decreased (-0.05%) to 97.979% when pulling ecb6f2f on refactor_to_use_to_stdout_matcher into b00493d on master.

coveralls commented Nov 18, 2017

Coverage decreased (-0.05%) to 97.979% when pulling ecb6f2f on refactor_to_use_to_stdout_matcher into b00493d on master.

coveralls commented Nov 18, 2017

Coverage decreased (-0.05%) to 97.979% when pulling ecb6f2f on refactor_to_use_to_stdout_matcher into b00493d on master.


          Switches $stdout redirection to rspec method

176feaf

* Rspec 3 adds the `output(args).to_stdout` method
* http://rspec.info/blog/2014/05/notable-changes-in-rspec-3/#new-output-matcher
* Means it’s a lot easier to do things like run pry, as stdout isn’t stuck
* Refactoring tests to change to next method

petems force-pushed the refactor_to_use_to_stdout_matcher branch from ecb6f2f to 176feaf Compare

November 18, 2017 18:12

petems closed this

petems deleted the refactor_to_use_to_stdout_matcher branch

November 18, 2017 18:12

petems restored the refactor_to_use_to_stdout_matcher branch

November 18, 2017 18:13

coveralls commented Nov 18, 2017

Coverage decreased (-0.05%) to 97.978% when pulling 176feaf on refactor_to_use_to_stdout_matcher into b00493d on master.

2 similar comments

coveralls commented Nov 18, 2017

Coverage decreased (-0.05%) to 97.978% when pulling 176feaf on refactor_to_use_to_stdout_matcher into b00493d on master.

coveralls commented Nov 18, 2017 •

edited

Loading

Coverage decreased (-0.05%) to 97.978% when pulling 176feaf on refactor_to_use_to_stdout_matcher into b00493d on master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet