Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update certificate chain #209

Closed
wants to merge 2 commits into from
Closed

Update certificate chain #209

wants to merge 2 commits into from

Conversation

odedd
Copy link

@odedd odedd commented Jan 9, 2022

No description provided.

timothystewart6 and others added 2 commits January 8, 2022 18:20
This seems to work just fine with the new certificate.
@timothystewart6
Copy link

@peter-murray any chance for a review, merge, and release?

@timothystewart6
Copy link

Nice work @odedd I am not sure how to get the 3rd part of the chain but I tested your changes locally against my custom twitch bot and it worked. Thanks!

@peter-murray
Copy link
Owner

What version are you looking for this fix to end up in? 4.x or 5.x? The main branch is not where the 5.x (a.k.a current) versions are.

@odedd
Copy link
Author

odedd commented Jan 11, 2022

Thank you peter.
This fix in currently intended for the 4.x branch (that's what I'm using) and I think it's needed as there are other projects still reliant on it, and without it the project breaks. It might also be needed for v5 if it still needs the cert for discovery.meethue.com

@peter-murray
Copy link
Owner

Versions 4.0.11 and 5.0.0-beta.10 have been released with this fix in it. looks likely another release will be required in April once this certificate expires again, the joy of actually enforcing SSL checks 😢

@timothystewart6
Copy link

Thank you so much!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants