Prepare for 2.7.10 release #720
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aeroastro
reviewed
Mar 17, 2019
| - Revert frozen string change (schneems) | ||
| - Advertise supports_cached_versioning? in DalliStore (schneems) | ||
| - Better detection of fork support, to allow specs to run under Truffle Ruby | ||
| - Update logging for over max size to log as error |
There was a problem hiding this comment.
@petergoldstein
Would you mind if you could give credit for @aeroastro and @deepj here?
It would be like this.
- Better detection of fork support, to allow specs to run under Truffle Ruby (deepj, #712)
- Update logging for over max size to log as error (Takumasa Ochi, #715)The original pull requests are here.
#712 #715
Although you have replaced each Pull Request with your commit, IMHO, it would be really grateful if you could give credit to original contributors. I believe giving legitimate credit would foster future contributions and contribute to the quality of Dalli as a gem.
There was a problem hiding this comment.
Sure. An oversight on my part.
I added the contributor reference in the manner Dalli has done historically - just by referencing the Github username.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.