Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix empty unnamed struct matcher generation #109

Merged
merged 1 commit into from
Oct 15, 2020

Conversation

p-jahn
Copy link
Contributor

@p-jahn p-jahn commented Oct 13, 2020

Fixes #101

  • by replacing the name of unnamed struct{} types
  • restrictive naming because non-empty struct{} types cannot be handled (yet) and are excluded here
    return nil, p.errorf(v.Pos(), "can't handle non-empty unnamed struct types")

@petergtz
Copy link
Owner

Super cool! Nothing to add :-). Thanks very much, @p-jahn . Merging!

@petergtz petergtz merged commit 8eedc00 into petergtz:develop Oct 15, 2020
@p-jahn p-jahn deleted the anonymous-struct branch October 15, 2020 09:52
@jpopadak
Copy link
Contributor

🙇🏼 Thank you! :) Allows me to get rid of: rm internal/service/matchers/recv_chan_of_struct{}.go

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants