Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix style values containing upper-case characters #85

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

zhangbenber
Copy link

inlineStyleToObject('background:url(https://test.com/IMAGE.png)') returns:
before: { background: 'url(https://test.com/image.png)' }
after: { background: 'url(https://test.com/IMAGE.png)' }

@coveralls
Copy link

coveralls commented Mar 23, 2021

Coverage Status

Coverage remained the same at 100.0% when pulling 1a64a90 on zhangbenber:fix-style-upper-case into e89bba4 on wrakky:master.

@mrdrogdrog
Copy link

mrdrogdrog commented Aug 30, 2021

@zhangbenber because this repository seems to be rather unmaintained, we at hedgedoc created a hard fork of the library and added some improvements. I would like to add your change to our fork (or you do it yourself with a PR). Are you okay with that?

@zhangbenber
Copy link
Author

@zhangbenber because this repository seems to be rather unmaintained, we at hedgedoc created a hard fork of the library and added some improvements. I would like to add your change to our fork (or you do it yourself with a PR). Are you okay with that?

Great. Feel free to do that.

@mrdrogdrog
Copy link

Already done. Thanks :)

orrisroot added a commit to orrisroot/react-html-parser that referenced this pull request May 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants