Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IE subpixel rounding breaks everything #42

Closed
corysimmons opened this issue Apr 2, 2015 · 14 comments
Closed

IE subpixel rounding breaks everything #42

corysimmons opened this issue Apr 2, 2015 · 14 comments

Comments

@corysimmons
Copy link
Contributor

Seriously, I hate this browser more and more every day.

@corysimmons
Copy link
Contributor Author

Try isolation technique. If that doesn't work. Kill self.

@corysimmons
Copy link
Contributor Author

Seems like it works. Need to do some more tests.

@dmitrykiselyov
Copy link
Contributor

Its ok, grid just dancing 😄 IE patry 💥
calc(100% * 1/3 - 0.01px - (30px - 30px /3)) works this way - 0.01px

@corysimmons
Copy link
Contributor Author

Gah! Why couldn't you have said that 3 hours earlier! I've been converting the whole thing over to the isolation method!

@dmitrykiselyov
Copy link
Contributor

or calc(99.99% * 1/3 - (30px - 30px /3))

@corysimmons
Copy link
Contributor Author

Awesome! Thanks @dmitrykiselyov 👍

Fixed 2cb9c9e

@dmitrykiselyov
Copy link
Contributor

no no no 99.99% 😄
better -0.01px

@corysimmons
Copy link
Contributor Author

Why 99.99% or -0.01px?

99.999% seems to work fine and has better precision?

@dmitrykiselyov
Copy link
Contributor

with a large width, the difference between 99.99 and 0.01can be 1px and >

@corysimmons
Copy link
Contributor Author

How large? I'm on a 2880 x 1800 retina and it works fine.

@corysimmons
Copy link
Contributor Author

I'll take your word for it.

@corysimmons
Copy link
Contributor Author

Fixed 44234ec

@corysimmons
Copy link
Contributor Author

I may end up going with isolation anyway (depending on if I can get the move() formula working easier with it or not), but this is a really great hotfix. Thanks again 👍

@dmitrykiselyov
Copy link
Contributor

I tested again, and there is no difference between 99.99% and 0.01 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants