Separate Envelope
validation from construction
#560
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This change moves Envelope validation out of constructors, and into a separate
Validate
method. This is similar to the recent changes for regular geometries.It includes two further small breaking changes, so that all breaking changes are bundled together:
The
ExtendToIncludeXY
method is renamed toExpandToIncludeXY
(to be consistent withExpandToIncludeEnvelope
).The
NewEnvelope
now accepts a variadic list ofXY
rather than a slice ofXY
. This is just a small ergonomic improvement.Check List
Have you:
Added unit tests? Yes.
Add cmprefimpl tests? (if appropriate?) N/A
Updated release notes? (if appropriate?) Yes.
Related Issue