Separate Envelope validation from construction
#560
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change moves Envelope validation out of constructors, and into a separate `Validate` method. This is similar to the recent changes for regular geometries. It includes two further small breaking changes, so that all breaking changes are bundled together: - The `ExtendToIncludeXY` method is renamed to `ExpandToIncludeXY` (to be consistent with `ExpandToIncludeEnvelope`). - The `NewEnvelope` now accepts a variadic list of `XY` rather than a slice of `XY`. This is just a small ergonomic improvement.
albertteoh
approved these changes
Oct 13, 2023
| @@ -8,6 +8,17 @@ YYYY-MM-DD | |||
|
|
|||
| - Simplifies the internal representation of the `Envelope` type. | |||
|
|
|||
| - **Breaking change**: Renames `Envelope`'s `ExtendToIncludeXY` method to | |||
| `ExpandToIncludeXY`. This makes the names of the `ExpandToIncludeXY` and | |||
There was a problem hiding this comment.
The name change also better expresses what it's doing.
Base automatically changed from
better_nan_handling_in_fastmin_and_fastmax
to
master
October 15, 2023 18:26
Co-authored-by: Albert <26584478+albertteoh@users.noreply.github.com>
|
Thanks for reviewing @albertteoh 🙇 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This change moves Envelope validation out of constructors, and into a separate
Validatemethod. This is similar to the recent changes for regular geometries.It includes two further small breaking changes, so that all breaking changes are bundled together:
The
ExtendToIncludeXYmethod is renamed toExpandToIncludeXY(to be consistent withExpandToIncludeEnvelope).The
NewEnvelopenow accepts a variadic list ofXYrather than a slice ofXY. This is just a small ergonomic improvement.Check List
Have you:
Added unit tests? Yes.
Add cmprefimpl tests? (if appropriate?) N/A
Updated release notes? (if appropriate?) Yes.
Related Issue