Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The dependency on WinRPM has to be enclosed with @windows. #9

Merged
merged 1 commit into from
Jan 31, 2018
Merged

The dependency on WinRPM has to be enclosed with @windows. #9

merged 1 commit into from
Jan 31, 2018

Conversation

sambitdash
Copy link
Contributor

Did not include the Windows guard before WinRPM which creates unnecessary errors in non-Windows builds. Now fixed.

@coveralls
Copy link

coveralls commented Jan 30, 2018

Pull Request Test Coverage Report for Build 31

  • 0 of 0 (NaN%) changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 44.444%

Totals Coverage Status
Change from base Build 29: 0.0%
Covered Lines: 28
Relevant Lines: 63

💛 - Coveralls

@codecov-io
Copy link

codecov-io commented Jan 30, 2018

Codecov Report

Merging #9 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master       #9   +/-   ##
=======================================
  Coverage   44.44%   44.44%           
=======================================
  Files           1        1           
  Lines          63       63           
=======================================
  Hits           28       28           
  Misses         35       35

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4112c20...149ec13. Read the comment docs.

@peterwittek
Copy link
Owner

I was wondering about that. Thanks.

@peterwittek peterwittek merged commit 88b48b4 into peterwittek:master Jan 31, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants