Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix #487: compatibility with python3.8 in petl.timings.clock() #516

Merged
merged 1 commit into from
Sep 12, 2020
Merged

fix #487: compatibility with python3.8 in petl.timings.clock() #516

merged 1 commit into from
Sep 12, 2020

Conversation

juarezr
Copy link
Member

@juarezr juarezr commented Sep 12, 2020 •
edited
Loading

This PR has the objective of fix #487

Changes

  1. Fixed a compatibility issue with python3.8 in petl.timings.clock()

Checklist

Checklist for for pull requests including new code and/or changes to existing code...

  • Code
    • Includes unit tests
    • All changes documented in docs/changes.rst
  • Testing
    • (Optional) Tested local against remote servers
    • Travis CI passes (unit tests run under Linux)
    • AppVeyor CI passes (unit tests run under Windows)
    • Unit test coverage has not decreased (see Coveralls)
  • Changes
    • Ready to review
    • Ready to merge

@juarezr juarezr added Bug It must work in all situations, but this failed Maintainability Issues for code modernization, improve development, testing labels Sep 12, 2020
@coveralls
Copy link

coveralls commented Sep 12, 2020 •
edited
Loading

Coverage Status

Coverage increased (+0.0006%) to 91.957% when pulling 5825211 on juarezr:fix_py38 into a66a640 on petl-developers:master.

@juarezr juarezr merged commit 0a74c0e into petl-developers:master Sep 12, 2020
@juarezr juarezr deleted the fix_py38 branch September 12, 2020 01:01
@juarezr juarezr linked an issue Sep 24, 2020 that may be closed by this pull request
time.clock was removed in Python 3.8 in favor of time.perf_counter/time.process_time #487
Closed
@juarezr juarezr changed the title fix #484: compatibility with python3.8 in petl.timings.clock() fix #487: compatibility with python3.8 in petl.timings.clock() Sep 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Bug It must work in all situations, but this failed Maintainability Issues for code modernization, improve development, testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

time.clock was removed in Python 3.8 in favor of time.perf_counter/time.process_time
2 participants
@juarezr @coveralls